Skip to content

Create an API for safely accessing BMP header fields

Albert ARIBAUD u-boot 1 version New

Get series with b4
b4 am 20130204151956.0c0e8486@lilith

Versions newest first

  1. v1 Latest0 of 5 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 5 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [U-Boot] [PATCH 0/5] Create an API for safely accessing BMP header fields

Hi Nikita,

Quoted 9 lines · Nikita Kiryanov

Hi Albert,

Quoted 5 lines · Albert ARIBAUD

IIRC, you has submitted a fix so that BMP loads would result in correctly aligned fields and thus no need for accessors. Why this change of mind?

Quoted 4 lines

I did mention that I consider that fix as temporary. I believe this fix is better because it addresses the issue everywhere and does so in a more maintainable way (does not require the address fix to be duplicated everywhere there is a problem).

I actually like the new fix less, as it adds an API where there is no need of one -- it's not like the implementation of BMP is at risk of changing. What is the problem in fixing the load address at load time and then passing this fixed address around?

Amicalement,

Signature · 1 line
Albert.