Skip to content

Create an API for safely accessing BMP header fields

Albert ARIBAUD u-boot 1 version New

Get series with b4
b4 am 20130204162528.2602782a@lilith

Versions newest first

  1. v1 Latest1 of 5 patches 0 repliesNew

1 of 5 patches is in this archive. The cover letter announces 5.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5Add bmp_layout module for accessing BMP header data+0 -07 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [U-Boot] [PATCH 0/5] Create an API for safely accessing BMP header fields

Hi Nikita,

Quoted 20 lines · Nikita Kiryanov
Quoted 19 lines · Albert ARIBAUD

Hi Nikita,

Quoted 13 lines · Nikita Kiryanov

Hi Albert,

Quoted 5 lines · Albert ARIBAUD

IIRC, you has submitted a fix so that BMP loads would result in correctly aligned fields and thus no need for accessors. Why this change of mind?

I did mention that I consider that fix as temporary. I believe this fix is better because it addresses the issue everywhere and does so in a more maintainable way (does not require the address fix to be duplicated everywhere there is a problem).

Quoted 7 lines
Quoted 4 lines

I actually like the new fix less, as it adds an API where there is no need of one -- it's not like the implementation of BMP is at risk of changing. What is the problem in fixing the load address at load time and then passing this fixed address around?

The problem is that it makes the U-Boot display subsystems broken in terms of what kind of programming interface they provide.

I'm not sure I understand what this means. Once all places that construct BMPs in memory are fixed so that they don't misalign, and documentation is there to tell about the issue, what exactly remains broken?

Quoted 4 lines

The load address fix has to be applied in every code path that leads to a BMP being loaded and read in memory. This means that anyone who wants to implement some BMP related functionality needs to care about this architecture/memory issue, and actively circumvent it.

Yes; but it is only a matter of getting the properly aligned address from the non-aligned one, which a simple macro is enough to provide; the rest, namely accessing fields, does not have to be turned into an API, nor does it benefit from it. Besides, switching to an API requires searching every place where BMPs are used, just like fixing addressing does.

Quoted 2 lines

This isn't good design. If I'm manipulating BMPs I should only care about my BMPs, not hardware issues.

Except that you have to, because you're not simply manipulating BMPs, you're manipulating them in a context where alignment is required.

Amicalement,

Signature · 1 line
Albert.