Skip to content

Create an API for safely accessing BMP header fields

Tom Rini u-boot 1 version New

Get series with b4
b4 am 20130205145852.GA19886@bill-the-cat

Versions newest first

  1. v1 Latest0 of 5 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 5 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [U-Boot] [PATCH 0/5] Create an API for safely accessing BMP header fields
Quoted 19 lines · Albert ARIBAUD

Hi Nikita,

Quoted 9 lines · Nikita Kiryanov

Hi Albert,

Quoted 5 lines · Albert ARIBAUD

IIRC, you has submitted a fix so that BMP loads would result in correctly aligned fields and thus no need for accessors. Why this change of mind?

Quoted 4 lines

I did mention that I consider that fix as temporary. I believe this fix is better because it addresses the issue everywhere and does so in a more maintainable way (does not require the address fix to be duplicated everywhere there is a problem).

Quoted 4 lines

I actually like the new fix less, as it adds an API where there is no need of one -- it's not like the implementation of BMP is at risk of changing. What is the problem in fixing the load address at load time and then passing this fixed address around?

OK, so I'm wondering. Isn't this an example of where our idea that unaligned accesses are a software problem to fix, rather than an area to let the hardware fixup for us, when able, is wrong?

In other words, a real life example of why we should go with -munaligned-access being set for v7, set the HW bit and let things go?

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130205/8b2b04f4/attachment.pgp>