ARM: samsung-time: Prepare for multiplatform support
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest0 of 14 patches 0 repliesNew
- v40 of 14 patches 0 repliesSuperseded
- v2 posting 2/20 of 12 patches 0 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 posting 1/2 | 0 of 12 patches | 0 replies | Superseded |
Patches in v5 No applies recorded yet
None of the 14 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.
Cover letter [PATCH v5 00/14] ARM: samsung-time: Prepare for multiplatform support
Am Samstag, 13. April 2013, 00:26:43 schrieb Arnd Bergmann:
Quoted 28 lines · On Saturday 13 April 2013 00:22:48 Heiko St?bner wrote:
Quoted 7 lines
Without dt support, you get this:
CCdrivers/clocksource/samsung_pwm.o
drivers/clocksource/samsung_pwm.c:620: warning:
?samsung_pwm_clocksource_init_of? defined but not usedSo, something like the following might be necessary
That patch should not be required any more with the definition
#ifdef
CONFIG_CLKSRC_OF
extern voidclocksource_of_init(void);#define CLOCKSOURCE_OF_DECLARE(name, compat, fn) \ static const struct of_device_id __clksrc_of_table_##name \ __used __section(__clksrc_of_table) \ = { .compatible = compat, \ .data = (fn == (clocksource_of_init_fn)NULL) ? fn : fn } #else static inline void clocksource_of_init(void) {} #define CLOCKSOURCE_OF_DECLARE(name, compat, fn) \ static const struct of_device_id __clksrc_of_table_##name \ __attribute__((unused)) \ = { .compatible = compat, \ .data = (fn == (clocksource_of_init_fn)NULL) ? fn : fn } #endif
Quoted 3 lines
which turns the ?samsung_pwm_clocksource_init_of? function into an unused symbol that gets silently dropped by gcc, at least in theory. Are you using the latest clksrc/cleanup branch as a base?
Nope, I just put the stuff on top of all the other changes. So it seems everything is fine and working ... very nice :-)
Heiko