Skip to content

SERIAL: OMAP: Remove idle handling from driver

Felipe Balbi linux-arm-kernel linux-omap 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 2 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC/RFT PATCH 0/2] SERIAL: OMAP: Remove idle handling from driver

Hi,

Quoted 5 lines · Santosh Shilimkar
Quoted 5 lines
Quoted 4 lines

If I read the code correctly there's nothing setting oh->mux during DT boot. The only caller to omap_hwmod_mux_init() (which allocates and returns omap_hwmod_mux_info pointer) is arch/arm/mach-omap2/devices.c::omap4_keyboard_init(). This has nothing

Quoted 7 lines
Quoted 3 lines

actually arch/arm/mach-omap2/serial.c::omap_serial_init_port() also calls that, but it's also not used during DT boots.

DT boot, all the function pointers are broken so wakeup as well as slave idle-mode is broken. Nothing new here. Serial file does set the pads as you noticed and this is what can be offloaded to generic pint control which can triggered from driver.

fair enough, understood now.

cheers

Signature · 8 lines
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130218/10c134e7/attachment.sig>