Skip to content

*** SUBJECT HERE ***

Tom Rini u-boot 1 version New

Get series with b4
b4 am 20130221015058.GO12654@bill-the-cat

Versions newest first

  1. v2 Latest0 of 11 patches 0 repliesNew

Patches in v2 No applies recorded yet

None of the 11 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [U-Boot] [PATCH v2 00/11] *** SUBJECT HERE ***
Quoted 44 lines · Sonic Zhang

Hi Wolfgang,

Quoted 22 lines · Wolfgang Denk

Dear Sonic Zhang,

please provide a useful Subject: line - "*** SUBJECT HERE ***" is not exactly helpful.

Quoted 3 lines · In message <[email protected]> you wrote:

The v2 patches
1) fix most checkpatch issues mentioned by Wolfgang

Hm... I'm sorry, but this information is not really helpful. So it seems you decided not to fix all issues, but you don't tell us which ones you ignored, or why.

I still see thousands of lines over 80 characters, plus a number of
trailing statements should be on next line, code indent should use tabs where possible, do not add new typedefs,
Whitespace before semicolon,
warnings and errors.

Quoted 2 lines

Please fix these!!

Sorry, I forget to check the serial patch after fixing the unreadable port muxing code.
But, where is the "Whitespace before semicolon"? my checkpatch.pl doesn't report this issue.

Quoted 11 lines
Quoted 7 lines

2) remove unrelated dma structure change patch
3) replace unreable macro in dma and uart structures with normal types.
4) replace unreable macro in uart peripheral portmux configuration with clear inline function.
5) clean up and merge redundant #ifdef's
6) spearate declarations and code by a blankline
7) remove the values for variables in blackfin config headers whose values are useless
8) replace run-time variable with new macro when adding 4M byte CPLB entries.

Please provide a more detailed list which review comments you processed, and which you decided to ignore, and why.

Quoted 8 lines
Quoted 6 lines

Please provide a more detailed list which review comments you processed, and which you decided to ignore, and why.

Note: this history of changes is supposed to be (also) in the patches itself, not (only) in the cover letter.

OK. I will put all change logs into the patches respectively.

Making use of patman (see tools/patman) can help both in that it will generate the emails for you, based on you adding the right information to your commits, and it will run the same checkpatch that Wolfgang is running as well.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130220/6094058a/attachment.pgp>