Skip to content

Convert highbank to use PSCI calls

Will Deacon linux-arm-kernel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 4 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 4 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] Convert highbank to use PSCI calls

Hi Rob,

Quoted 6 lines · Rob Herring

From: Rob Herring <[email protected]>

This series converts highbank to use PSCI calls for secondary core boot, hotplug, cpuidle, suspend/resume, reset, and poweroff. Doing this removes about 200 lines of platform code (1/3 of it) and abstracts out the A9 and A15 differences (some of which are not yet in place).

This is great, nice work!

Quoted 4 lines

Will, I'm using the id field to specify system level events which are highbank specific. I worry that the id field will be abused for things that could be standardized. Having standard PSCI calls for reset and poweroff would avoid this for highbank.

I don't like using the ID field for this because it places some of the number space in the device tree binding and other parts in the platform code. It might be better to use the bottom 16 bits of the power_state argument to CPU_OFF (which are designated as platform specific anyway) to indicate that you actually want a system-wide operation to take place.

Since this document is currently undergoing a fairly major update (which will hopefully be released soon), I'll go and check with the authors to see if they have already considered this.

Cheers,

Will