DEVICE_DELETED event
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v9 Latest3 patches 6 repliesIn review
- v83 patches 7 repliesSuperseded
- v71 of 3 patches 0 repliesSuperseded
Earlier versions · 7
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v6 | 3 patches | 7 replies | Superseded | |
| v5 | 3 patches | 2 replies | Superseded | |
| v4 | 1 patch | 8 replies | Superseded | |
| v3 posting 2/2 | 1 patch | 3 replies | Superseded | |
| v3 posting 1/2 | 1 patch | 1 reply | Superseded | |
| v2 | 1 patch | 4 replies | Superseded | |
| v1 | 1 patch | 24 replies | Superseded |
Changes in v9 from the cover letter
- reorder qom destruction so no need to change unparent
Patches in v9 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | qdev: DEVICE_DELETED eventQMP/ hw/ include/ +2 more | +32 | 1 reply | |
| 2/3 | qom: call class destructor before unparentqom/ | +3 | 3 replies | |
| 3/3 | qmp: add path to device_deleted eventQMP/ hw/ | +8 | 1 reply |
Reviews trailers per patch
2 of 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Markus Armbruster | Andreas Färber |
|---|---|---|
| Series | R-b | |
| 1/3 | A-b | |
| 2/3 | ||
| 3/3 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v9 0/3] DEVICE_DELETED event
libvirt has a long-standing bug: when removing the device, it can request removal but does not know when the removal completes. Add an event so we can fix this in a robust way.
First patch only adds the event with ID, second patch adds a path field. Split this way for ease of backport (stable downstreams without QOM would want to only take the first patch).
Event without fields is still useful as management can use it to poll device list to figure out which device was removed.
If there are no more comments I'll stick this on my pci branch.
Changes from v8:
- reorder qom destruction so no need to change unparent
Changes from v7:
- none, v7 was malformed series sent by mistake
Changes from v6:
- make empty event use data: {}, Markus prefers this
Changes from v5:
- Emit an empty event on unnamed devices in patch 1/3, as suggested by Markus
Changes from v4:
- Add extra triggers and extra fields as requested by Markus
Changes from v3:
- Document that we only emit events for devices with and ID, as suggested by Markus
Changes from v2:
- move event toward the end of device_unparent, so that parents are reported after their children, as suggested by Paolo
Changes from v1:
- move to device_unparent
- address comments by Andreas and Eric
Signature · 18 lines
Anthony Liguori Michael S. Tsirkin (3): qdev: DEVICE_DELETED event qom: call class destructor before unparent qmp: add path to device_deleted event QMP/qmp-events.txt | 18 ++++++++++++++++++ hw/qdev.c | 14 ++++++++++++++ include/monitor/monitor.h | 1 + monitor.c | 1 + qapi-schema.json | 4 +++- qom/object.c | 6 +++--- 6 files changed, 40 insertions(+), 4 deletions(-) -- MST