RFC: exynos multiplatform support
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest0 of 23 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 23 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 00/23] RFC: exynos multiplatform support
Quoted 11 lines · Tomasz Figa
I have a question regarding making this an MFD driver.
As you know, the main clocksource driver must be initialized early, from
init_timecallback ofmachine_desc. How does using the MFD subsystem fit into this scheme?
P.S. I'm still not convinced about any benefits of options 2 and 3 over option 1, which has the obvious advantage of requiring least amount of changes to existing code and not binding the PWM and clocksource drivers together (on Exynos SoCs only the PWM driver is used, clocksource is handled by different hardware block - MCT).
I think the main motivation for the MFD here is that you have a shared register set, which would be described as a single device node in DT as its natural representation, but it's not easy to have two drivers be responsible for the same platform device. Similarly, the Linux resource handling tries hard to ensure that multiple device drivers do not share a single register set.
If you have an MFD driver, that could bind do the platform_device created from the DT device node, and provide a simple interface for both the timer and the pwm driver to talk to, without exposing those registers directly. Or you could use the syscon regmap approach to expose those registers in a more controlled way. With syscon, you don't actually have to write an MFD driver but could just use the one that is already there.
Since you want the timer driver to be available really early, you could also make that timer driver the master and expose an interface for the PWM driver to use.
Arnd