Skip to content

coredump: signal_pending() checks and cleanups

Oleg Nesterov lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3coredump: introduce dump_interrupted()fs/coredump.c+17 -34 replies
2/3coredump: factor out the setting of PF_DUMPCOREarch/x86/ia32/ia32_aout.c fs/binfmt_aout.c fs/binfmt_elf.c +2 more+2 -61 reply
3/3coredump: change wait_for_dump_helpers() to use wait_event_interruptible()fs/coredump.c+9 -61 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchMandeep Singh Baines
1/3A-b
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH -mm 0/3] coredump: signal_pending() checks and cleanups

Hello.

To remind, this replaces the previous series,

coredump-factor-out-the-setting-of-pf_dumpcore.patch freezer-do-not-send-a-fake-signal-to-a-pf_dumpcore-thread.patch coredump-make-wait_for_dump_helpers-freezable.patch

As Mandeep pointed out, 2/3 is not enough to make the coredump really freezable.

By discussion with Mandeep, we simply accept the fact that the freezer can truncate a core-dump, hopefully not a problem in practice.

2 and 3 become the "off-topic" cleanups but imho make sense anyway and can help if we decide to make the coredumping freezable.

Mandeep, I didn't dare to keep your ack on 3/3, the patch was updated a bit (s/freezable/interruptible + comments), I hope you can ack v2 too. And of course I hope you will review 1 and 2 as well.

Oleg.