Skip to content

tracing: ring-buffer selftest, cleanups, ftrace_dump() fix and document

Steven Rostedt lkml stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9ring-buffer: Add ring buffer startup selftestkernel/trace/Kconfig kernel/trace/ring_buffer.c+342 -00 replies
2/9tracing: Use pr_warn_once instead of open coded implementationkernel/trace/trace.c+2 -70 replies
3/9tracing: Use TRACE_MAX_PRINT instead of constantkernel/trace/trace.c+2 -20 replies
4/9tracing: Move find_event_field() into trace_events.ckernel/trace/trace.h kernel/trace/trace_events.c kernel/trace/trace_events_filter.c+32 -340 replies
5/9tracing: Convert trace_destroy_fields() to statickernel/trace/trace_events.c+1 -10 replies
6/9tracing: Fix comment about prefix in arch_syscall_match_sym_name()kernel/trace/trace_syscalls.c+1 -10 replies
7/9tracing: Rename trace_event_mutex to trace_event_semkernel/trace/trace_events.c kernel/trace/trace_output.c kernel/trace/trace_output.h+20 -200 replies
8/9tracing: Fix ftrace_dump()kernel/trace/trace.c kernel/trace/trace_selftest.c+31 -400 replies
9/9tracing: Update debugfs README filekernel/trace/trace.c+75 -145 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [for-next][PATCH 0/9] tracing: ring-buffer selftest, cleanups, ftrace_dump() fix and document

One more linux-next patch series.

The first patch is a ring buffer boot time selftest. A bug in my development code looked like the ring buffer was dropping events, and I wrote a test to make sure that wasn't the case. The bug ended up being a stupid mistake in my development code, but the ring buffer test seemed like a good idea to include in the kernel as an option.

Next is a series of clean ups by Jovi.

Jovi also pointed out issues with ftrace_dump(). It's been on my todo list to clean up ftrace_dump() for a long time, and finally decided to do so. It wasn't hard and was quick to do. There was a long standing bug where an NMI triggering a dump while another dump was happening could cause a deadlock. I marked that patch for stable, but since its really just a debugging tool and I don't recall ever hitting the deadlock (I might have), I decided it can wait for 3.10 and I'll do the backports when I get the "Failed to apply" messages from Greg Kroah-Hartman's stable scripts.

Last patch brings the README file in debugfs/tracing/ up to date with more useful information.

Enjoy!

-- Steve

Steven Rostedt (Red Hat) (3):
ring-buffer: Add ring buffer startup selftest
tracing: Fix ftrace_dump()
tracing: Update debugfs README file

zhangwei(Jovi) (6):
tracing: Use pr_warn_once instead of open coded implementation
tracing: Use TRACE_MAX_PRINT instead of constant
tracing: Move find_event_field() into trace_events.c
tracing: Convert trace_destroy_fields() to static
tracing: Fix comment about prefix in arch_syscall_match_sym_name()
tracing: Rename trace_event_mutex to trace_event_sem

----

 kernel/trace/Kconfig               |   23 +++
 kernel/trace/ring_buffer.c         |  319 ++++++++++++++++++++++++++++++++++++
 kernel/trace/trace.c               |  164 +++++++++++-------
 kernel/trace/trace.h               |    6 +-
 kernel/trace/trace_events.c        |   55 +++++--
 kernel/trace/trace_events_filter.c |   29 +---
 kernel/trace/trace_output.c        |   16 +-
 kernel/trace/trace_output.h        |    2 +-
 kernel/trace/trace_selftest.c      |    9 +-
 kernel/trace/trace_syscalls.c      |    2 +-
 10 files changed, 506 insertions(+), 119 deletions(-)