ARM: OMAP2+: GPMC clean-up and DT update
Get series with b4
b4 am 20130317053452.GB9796@localhostVersions newest first
- v3 Latest2 of 18 patches 0 repliesNew
2 of 18 patches are in this archive. The cover letter announces 18.
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 2/18 | ARM: OMAP2+: Add variable to store number of GPMC waitpins | +0 | 1 reply | |
| 10/18 | ARM: OMAP2+: Add function to read GPMC settings from device-tree | +0 | 1 reply |
Reviews trailers per patch
None of the 2 patches has a Reviewed-by or Acked-by.
| Patch | Ezequiel Garcia |
|---|---|
| Series | T-b |
| 2/18 | |
| 10/18 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH V3 00/18] ARM: OMAP2+: GPMC clean-up and DT update
Quoted 85 lines · Jon Hunter
While adding device-tree support for NOR memories, it became apparent that there is no common way for configuring various GPMC settings for devices that interface to the GPMC. These settings include bus-width, synchronous/asynchronous mode, burst settings, wait monitoring etc. Therefore, to simplify the GPMC code and add device-tree support for NOR, it was first necessary to consolidate how these settings are programmed.
Series based upon Mark Jackson's patch [1] and Ezequiel Garcia GPMC clean-up series [2]. Entire series available here [3].
V3 changes:
- Rebased on RMK'sIS_ERR_VALUE()patch and removed usage ofIS_ERR_VALUE()from series.
- Fixed BUG in NAND code introduced in V2 by makinggpmc_settingsstructure a local variable (I forgot to initialise structure to zero).
- Added fix from Javier to correct return value fromgpmc_probe_nor().V2 changes:
- Madegpmc_settingsstructure local ingpmc_nand_init().
- Useresource_size()API inprobe_nor().
- Add kernel-doc forgpmc_cs_program_settings()function.
- Useof_platform_device_create()to register NOR devices inprobe_nor().
- Add support for GPMC address-address-data multiplexing which required changing GPMC DT property "gpmc,mux-add-data" to store a 32-bit value and changingmux_add_datamember ofgpmc_settingsto be a 32-bit type instead of bool.
- Add detection for incorrect GPMC chip-select base addresses.
- Cleaned-up code ingpmc_mem_init()and changedgpmc_mem_init()so that it would not return an error when the GPMC driver is being probed.V1 changes:
- Clean-up/simplification of ONENAND initialisation code.
- Add a new GPMC structure to unify storage of various GPMC settings (that are non-timing related) for client devices and add a new function to program these settings in a common way.
- Migrate initialisation code for existing flash, usb and networking devices to use the new structure and function for GPMC settings.
- Add device-tree support for NOR flash memories.
- Add additional GPMC timing parameters to GPMC device-tree binding.
- Update GPMC NAND and ONENAND device-tree support to retrieve GPMC settings from device-tree.Testing includes:
- Boot testing on OMAP2420 H4, OMAP3430 SDP and OMAP4430 SDP with and without device-tree present.
- OMAP2420 H4 board has NOR flash and OMAP3430 SDP has NOR, NAND and ONENAND flash. So verified that flash is detected on boot as expected. Note additional patches [4] are required for OMAP2420 H4 and OMAP3430 SDP dts files in order to enable flash memory support.
- All of the above boards use GPMC for interfacing to a networking chip and so verified that networking is working wit this series. However, please note that networking is not currently supported on these boards when booting with DT and so networking is only tested without DT.[1] http://permalink.gmane.org/gmane.linux.ports.arm.omap/94765
[2] http://comments.gmane.org/gmane.linux.ports.arm.omap/93784
[3] https://github.com/jonhunter/linux/tree/omap-gpmc-for-v3.10
[4] https://github.com/jonhunter/linux/tree/omap-dt-for-v3.10Javier Martinez Canillas (1):
ARM: OMAP2+: return-ENODEVif GPMC child device creation failsJon Hunter (17):
ARM: OMAP2+: Simplify code configuring ONENAND devices
ARM: OMAP2+: Add variable to store number of GPMC waitpins
ARM: OMAP2+: Add structure for storing GPMC settings
ARM: OMAP2+: Add function for configuring GPMC settings
ARM: OMAP2+: Convert ONENAND to usegpmc_cs_program_settings()
ARM: OMAP2+: Convert NAND to usegpmc_cs_program_settings()
ARM: OMAP2+: Convert SMC91x to usegpmc_cs_program_settings()
ARM: OMAP2+: Convert TUSB to usegpmc_cs_program_settings()
ARM: OMAP2+: Don't configure of chip-select options in
gpmc_cs_configure()
ARM: OMAP2+: Add function to read GPMC settings from device-tree
ARM: OMAP2+: Add device-tree support for NOR flash
ARM: OMAP2+: Add additional GPMC timing parameters
ARM: OMAP2+: Convert NAND to retrieve GPMC settings from DT
ARM: OMAP2+: Convert ONENAND to retrieve GPMC settings from DT
ARM: OMAP2+: Detect incorrectly aligned GPMC base address
ARM: OMAP2+: Remove unnecesssary GPMC definitions and variable
ARM: OMAP2+: Allow GPMC probe to complete even if CS mapping fails
Quoted 15 lines
Documentation/devicetree/bindings/bus/ti-gpmc.txt | 48 +- Documentation/devicetree/bindings/mtd/gpmc-nor.txt | 98 ++++ .../devicetree/bindings/mtd/gpmc-onenand.txt | 3 + arch/arm/mach-omap2/gpmc-nand.c | 39 +- arch/arm/mach-omap2/gpmc-onenand.c | 110 ++-- arch/arm/mach-omap2/gpmc-smc91x.c | 30 +- arch/arm/mach-omap2/gpmc.c | 524 +++++++++++++++----- arch/arm/mach-omap2/gpmc.h | 37 +- arch/arm/mach-omap2/usb-tusb6010.c | 62 ++- 9 files changed, 691 insertions(+), 260 deletions(-) create mode 100644 Documentation/devicetree/bindings/mtd/gpmc-nor.txtSignature · 1 line
1.7.10.4
Looks really good!
FWIW, On my OMAP3630 (IGEPv2) board, both DT and non-DT booted and read the OneNAND device.
Thanks,
Signature · 3 lines
Ezequiel Garc?a, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com