Skip to content

v3 RCU idle/no-CB changes for 3.10

Paul E. McKenney lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15rcu: Remove restrictions on no-CBs CPUsinit/Kconfig kernel/rcutree.c kernel/rcutree.h +1 more+57 -1290 replies
2/15rcu: Provide compile-time control for no-CBs CPUsinit/Kconfig kernel/rcutree_plugin.h+51 -00 replies
3/15rcu: Introduce proper blocking to no-CBs kthreads GP waitskernel/rcutree.c kernel/rcutree.h kernel/rcutree_plugin.h+127 -200 replies
4/15rcu: Add event tracing for no-CBs CPUs' callback registrationkernel/rcutree_plugin.h+7 -00 replies
5/15rcu: Add event tracing for no-CBs CPUs' grace periodsinclude/trace/events/rcu.h kernel/rcutree_plugin.h+85 -00 replies
6/15rcu: Distinguish "rcuo" kthreads by RCU flavorDocumentation/kernel-parameters.txt init/Kconfig kernel/rcutree.c +2 more+20 -130 replies
7/15rcu: Export RCU_FAST_NO_HZ parameters to sysfskernel/rcutree_plugin.h+20 -110 replies
8/15rcu: Accelerate RCU callbacks at grace-period endkernel/rcutree.c+13 -80 replies
9/15rcu: Make RCU_FAST_NO_HZ take advantage of numbered callbacksDocumentation/kernel-parameters.txt include/linux/rcupdate.h init/Kconfig +4 more+149 -3130 replies
10/15rcu: Rearrange locking in rcu_start_gp()kernel/rcutree.c+2 -40 replies
11/15rcu: Repurpose no-CBs event tracing to future-GP eventsinclude/trace/events/rcu.h kernel/rcutree_plugin.h+40 -380 replies
12/15rcu: Push lock release to rcu_start_gp()'s callerskernel/rcutree.c kernel/rcutree_plugin.h+12 -170 replies
13/15rcu: Rename n_nocb_gp_requests to need_future_gpkernel/rcutree.h kernel/rcutree_plugin.h+11 -110 replies
14/15rcu: Abstract rcu_start_future_gp() from rcu_nocb_wait_gp()kernel/rcutree.c kernel/rcutree.h kernel/rcutree_plugin.h+130 -990 replies
15/15rcu: Make rcu_accelerate_cbs() note need for future grace periodskernel/rcutree.c+32 -180 replies

Reviews trailers per patch

None of the 15 patches has a Reviewed-by or Acked-by.

PatchDietmar Eggemann
1/15
2/15
3/15
4/15
5/15
6/15T-b
7/15
8/15
9/15
10/15
11/15
12/15
13/15
14/15
15/15

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH tip/core/rcu 0/15] v3 RCU idle/no-CB changes for 3.10

Hello!

This series contains changes to RCU_FAST_NO_HZ idle entry/exit and also removes restrictions on no-CBs CPUs.

1. Remove restrictions on no-CBs CPUs.
2. Allow some control of no-CBs CPUs at kernel-build time. The option
of most interest is probably the one that makes -all- CPUs be no-CBs CPUs.
3. Introduce proper blocking to grace-period waits for no-CBs CPUs.
4. Add event tracing for no-CBs CPU callback registration.
5. Add event tracing for no-CBs CPU grace periods.
6. Distinguish the no-CBs kthreads for the various RCU flavors.
Without this patch, CPU 0 would have up to three kthreads all named "rcuo0", which is less than optimal. These kthreads are now named "rcuob/0", "rcuop/0", and "rcuos/0".
7. Export RCU_FAST_NO_HZ parameters to sysfs to allow run-time
adjustment.
8. Re-introduce callback acceleration during grace-period cleanup.
Now that the callbacks are associated with specific grace periods, such acceleration is idempotent, and it is now safe to accelerate more than needed. (In contrast, in the past, too-frequent callback acceleration resulted in infrequent RCU failures.)
9. Use the newly numbered callbacks to greatly reduce the CPU overhead
incurred at idle entry by RCU_FAST_NO_HZ. The fact that the callbacks are now numbered means that instead of repeatedly cranking the RCU state machine to try to get all callbacks invoked, we can instead rely on the numbering so that the CPU can take full advantage of any grace periods that elapse while it is asleep. CPUs with callbacks still have limited sleep times, especially if they have at least one non-lazy callback queued.
10-15. Allow CPUs to make known their need for future grace periods,
which is also used to reduce the need for frenetic RCU state-machine cranking upon RCU_FAST_NO_HZ entry to idle.
10. Move the release of the root rcu_node structure's ->lock
to then end of rcu_start_gp().
11. Repurpose no-CB's grace-period event tracing to that of
future grace periods, which share no-CB's grace-period mechanism.
12. Move the release of the root rcu_node structure's ->lock
to rcu_start_gp()'s callers.
13. Rename the rcu_node ->n_nocb_gp_requests field to
->need_future_gp.
14. Abstract rcu_start_future_gp() from rcu_nocb_wait_gp()
to that RCU_FAST_NO_HZ can use the no-CB CPUs mechanism for allowing a CPU to record its need for future grace periods.
15. Make rcu_accelerate_cbs() note the need for future
grace periods, thus avoiding delays in starting grace periods that currently happen due to the CPUs needing those grace periods being out of action when the previous grace period ends.

Changes since v2:

o Broke initial patch into smaller pieces.
o Significant additional testing completed.

Changes since v1:

o Fixed a deadlock in #1 spotted by Xie ChanglongX.
o Updated #2 to bring the abbreviations in line with conventional
per-CPU kthread naming.
o Moved the first two patches into their own group.

Thanx, Paul

 b/Documentation/kernel-parameters.txt |   35 -
 b/include/linux/rcupdate.h            |    1 
 b/include/trace/events/rcu.h          |   71 ++
 b/init/Kconfig                        |   71 ++
 b/kernel/rcutree.c                    |  279 +++++++---
 b/kernel/rcutree.h                    |   43 -
 b/kernel/rcutree_plugin.h             |  935 +++++++++++++---------------------
 b/kernel/rcutree_trace.c              |    2 
 8 files changed, 756 insertions(+), 681 deletions(-)