Skip to content

Marvell EBU thermal sensor consolidation

Andrew Lunn linux-arm-kernel linux-pm 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 of 16 patches 0 repliesNew

4 of 16 patches are in this archive. The cover letter announces 16.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
6/16thermal: mvebu: Convert to devm_ioremap_resource()+0 -01 reply
6/16thermal: mvebu: Convert to devm_ioremap_resource()+0 -00 replies
13/16thermal: mvebu: Add support for Marvell Dove SoC family+0 -00 replies
13/16thermal: mvebu: Add support for Marvell Dove SoC family+0 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/16] Marvell EBU thermal sensor consolidation
Quoted 6 lines · Ezequiel Garcia

This patchset is my first attempt at adding basic thermal sensor support on Armada 370 and Armada XP.

Given Armada 370/XP and the other Marvell SoC with thermal support, namely Kirkwood and Dove, have fairly similar thermal devices it made sense to integrate all of them into a single driver: mvebu-thermal.

Hi Ezequiel

I went this way to start with, merging Dove, Kirkwood and something which nearly worked for 370. But then i looked at the code, at how little is actually shared, and went back to separate drivers.

Kirkwood has no control registers, so needs a special case in the probe. The bit location of the temperate value moves around in the register. Each SoC needs its own initialization sequence.
Each SoC needs its own is_valid() function.
Each Soc needs its own formula to convert to milli centigrad.

I've never seen the datasheets for 370/XP, just a list of registers for
370. But i get the impression it has two temperate sensors, so should export two values?

Also, kirkwood will never be built into the same kernel as Dove/370/XP. So we end up with "bloat" in the driver, or at least a collection of #ifdefs.

In the end, i decided it was simpler and cleaner to just have separate drivers. This is something which we should think about and discuss.

Andrew