Skip to content

clock driver for sunxi

Mike Turquette linux-arm-kernel 3 versions – New

Get series with b4
b4 am 20130327015524.4014.17011@quantum

Versions newest first · linked by author and title

  1. v2 Latest posting 3/30 of 3 patches 0 repliesNew
  2. v2 posting 2/30 of 3 patches 0 repliesSuperseded
  3. v2 posting 1/30 of 3 patches 0 repliesSuperseded

Patches in v2 posting 3/3 No applies recorded yet

None of the 3 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] clock driver for sunxi

Quoting Maxime Ripard (2013-03-26 02:20:21)

Quoted 41 lines

Hi Mike,

Le 22/03/2013 17:40, Mike Turquette a ?crit :

Quoted 38 lines

Quoting Maxime Ripard (2013-03-22 03:22:25)

Quoted 37 lines

Hi Mike,

Le 21/03/2013 22:54, Mike Turquette a ?crit :

Quoted 29 lines

Quoting Emilio L?pez (2013-02-25 06:44:25)

Quoted 9 lines

Hello everyone,

This patchset adds basic clock support for sunxi devices. Currently, it implements support for the two oscillators, the main PLL, the CPU mux, its three divisor clocks and APB1. With this in place, it is possible to write a cpufreq driver and have it work, and with a little more code, represent the UART clocks correctly (I will be sending a separate patchset for this).

Quoted 6 lines

I have tested this driver successfully on a Cubieboard (A10, sun4i) using the cpufreq driver from the linux-sunxi tree after minor modifications (the clock names are not the same).

Any feedback will be highly appreciated

Emilio,

This is a nice series. I appreciate the amount of comments in the code, the kerneldoc and also the added sunxi clock documentation.

Concerning the discussion from the v1 series, I prefer for the struct clk instances in the tree to match 1-to-1 with hardware clocks. As the number of clocks in a system scales into the hundreds there are certainly advantages to having fewer clocks in the hierarchy, not the least of which is more easily associating these objects with hardware clocks during a deep debug session.

Quoted 2 lines

That can be changed at a later time if you wish. Do you want me to take the series into clk-next or do you just want my ack?

Thanks for your feedback!

Quoted 9 lines
Quoted 5 lines
Quoted 3 lines

Unless you have some objection, I was planning to merge it through my tree, with your Acked-by, of course.

Arnd would prefer to get this serie going through your tree, could you merge the patches 1/3 and 3/3 with my Acked-by?

Makes sense, as this is how we have merged other platform's DT/CCF support recently. Patches #1 & #3 are in clk-next.

Regards,
Mike

Quoted 7 lines

Thanks,
Maxime

Signature · 3 lines
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com