common.lcd: remove globals and cleanup
Get series with b4
b4 am 20130329120313.21ca8dc5@crubVersions newest first
- v2 Latest2 of 10 patches 0 repliesNew
2 of 10 patches are in this archive. The cover letter announces 10.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 7/10 | common/lcd: cosmetic: clean up a bit | +0 | 0 replies | |
| 10/10 | common/lcd.c: move the macro's to the c file | +0 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [U-Boot] [PATCH v2 00/10] common.lcd: remove globals and cleanup
Hi,
Quoted 58 lines · On Tue, 22 Jan 2013 21:44:06 +0100 Jeroen Hofstee <[email protected]> wrote:
As mentioned in http://lists.denx.de/pipermail/u-boot/2013-January/143459.html
there does not seem to be a good reason why the frame buffer driver provide the variables for the lcd internal logic. So lets just remove it. If there is any good reason for a framebuffer driver to "call up" it should do so by a function call and not change the lcd its internal state (and there is actually none doing so at the moment).This patchset first removes unused drivers and places drivers useing
common/lcd.cindrivers/video. Then removes the unneeded globals and thereafter finishes with some cleanups.This patch goes after http://patchwork.ozlabs.org/patch/209692/
"common/lcd.c: cleanup use of global variables"Version 2:
Marek Vasut <[email protected]>: use format-patch -M to detect moves Adjust the commit message not to exceed the max line length Fix malformed email address.
check-patch clean (adjusted a space in patch 6)
remove bouncing email addresses and add acks
patch 7 and 10 are unchanged and not repostedJeroen Hofstee (10):
lcd, amba: remove this driver since it is not used lcd, tegra: remove unused cursor functions lcd, mpc8xx: move the mpc8xx driver todrivers/videolcd, pxafb: move the pxafb todrivers/videocommon/lcd.c: cleanup use of global variablescommon/lcd.c: remove globallcd_basecommon/lcd: cosmetic: clean up a bit
lcd, fb: remove duplicated prototypes and unused code api/api_display: use the getters for console size infocommon/lcd.c: move the macro's to the c fileapi/api_display.c | 4 +- arch/arm/cpu/pxa/Makefile | 1 - arch/powerpc/cpu/mpc8xx/Makefile | 1 - board/mcc200/lcd.c | 21 +--- common/lcd.c | 117 +++++++++++--------- drivers/video/Makefile | 3 +- drivers/video/amba.c | 77 ------------- drivers/video/atmel_hlcdfb.c | 8 -- drivers/video/atmel_lcdfb.c | 8 -- drivers/video/exynos_fb.c | 14 +-- .../cpu/mpc8xx/lcd.c => drivers/video/mpc8xx_lcd.c | 58 +--------- .../arm/cpu/pxa/pxafb.c => drivers/video/pxa_lcd.c | 41 ------- drivers/video/tegra.c | 64 +---------- include/configs/R360MPI.h | 1 + include/configs/RBC823.h | 1 + include/configs/RPXlite_DW.h | 1 + include/configs/RRvision.h | 4 +- include/configs/TQM823L.h | 1 + include/configs/TQM823M.h | 1 + include/configs/lubbock.h | 1 + include/configs/lwmon.h | 1 + include/configs/palmld.h | 1 + include/configs/palmtc.h | 1 + include/configs/pxa255_idp.h | 1 +
Quoted 8 lines
include/configs/svm_sc8xx.h | 1 + include/configs/v37.h | 1 + include/configs/zipitz2.h | 1 + include/lcd.h | 71 +++--------- 28 files changed, 109 insertions(+), 396 deletions(-) delete mode 100644 drivers/video/amba.c rename arch/powerpc/cpu/mpc8xx/lcd.c => drivers/video/mpc8xx_lcd.c (92%) rename arch/arm/cpu/pxa/pxafb.c => drivers/video/pxa_lcd.c (93%)
Merged this series after rebasing, also merged patches 7 and 10 from previous series. Thanks!
Anatolij