Skip to content

uprobes/tracing: uretprobes

Oleg Nesterov lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 1 replyIn review
  2. v16 patches 10 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7uprobes/tracing: Generalize struct uprobe_trace_entry_headkernel/trace/trace.h kernel/trace/trace_uprobe.c+36 -310 replies
2/7uprobes/tracing: Introduce uprobe_{trace,perf}_print() helperskernel/trace/trace_uprobe.c+20 -90 replies
3/7uprobes/tracing: Introduce is_ret_probe() and uretprobe_dispatcher()kernel/trace/trace_uprobe.c+40 -20 replies
4/7uprobes/tracing: Make uprobe_{trace,perf}_print() uretprobe-friendlykernel/trace/trace_uprobe.c+25 -91 reply
5/7uprobes/tracing: Make register_uprobe_event() paths uretprobe-friendlykernel/trace/trace_uprobe.c+15 -40 replies
6/7uprobes/tracing: Make seq_printf() code uretprobe-friendlykernel/trace/trace_uprobe.c+13 -40 replies
7/7uprobes/tracing: Change create_trace_uprobe() to support uretprobeskernel/trace/trace_uprobe.c+7 -40 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchSrikar DronamrajuAnton Arapov
1/7A-b T-b
2/7A-b T-b
3/7A-b T-b
4/7A-b T-b
5/7A-b T-b
6/7A-b T-b
7/7A-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/7] uprobes/tracing: uretprobes
Quoted 21 lines · Steven Rostedt
Quoted 11 lines · Oleg Nesterov

On 04/08, Steven Rostedt wrote:

OK, will do.

Or. Instead of enum we can use "bool is_return". So, instead of

	if (is_ret_probe(tu))
		size = SIZEOF_TRACE_ENTRY(UPROBE_ENTRY_RETPROBE);
	else
		size = SIZEOF_TRACE_ENTRY(UPROBE_ENTRY_NORMAL);
Quoted 5 lines

we can do

	size = SIZEOF_TRACE_ENTRY(is_ret_probe(tu));

What do you like more?

Which ever is easier ;-)

Quoted 8 lines

I just hated the magic "1" and "2". As long as I (or any reviewer) does not need to go searching for numbers, and can easily figure out what is going on by looking at the code at hand, I'm happy.

Both the above satisfy that requirement.

Your "is_ret_probe(tu)" may have the added bonus of being less error prone.

OK, please see v2.

Change SIZEOF_TRACE_ENTRY/DATAOF_TRACE_ENTRY to accept "bool is_return" rather than "int nr".

Srikar, I preserved your acks, hopefully this is fine. But 4/7 still doesn't have your ack.

Oleg.