Skip to content

RCU callback-numbering simplifications for 3.11

Paul E. McKenney lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8rcu: Move code to apply callback-numbering simplificationskernel/rcutree.c+59 -590 replies
2/8rcu: Make __note_new_gpnum() check for ends of prior grace periodskernel/rcutree.c+3 -00 replies
3/8rcu: Rename note_new_gpnum() to note_gp_changes()kernel/rcutree.c+7 -60 replies
4/8rcu: Switch callers from rcu_process_gp_end() to note_gp_changes()kernel/rcutree.c kernel/rcutree_plugin.h+4 -290 replies
5/8rcu: Merge __rcu_process_gp_end() into __note_gp_changes()kernel/rcutree.c+6 -420 replies
6/8rcu: Eliminate check_for_new_grace_period() wrapper functionkernel/rcutree.c+3 -220 replies
7/8rcu: Inline trivial wrapper function rcu_start_gp_per_cpu()kernel/rcutree.c+1 -130 replies
8/8rcu: Move redundant call to note_gp_changes() into called functionkernel/rcutree.c+2 -80 replies

Reviews trailers per patch

None of the 8 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJosh Triplett
SeriesR-b
1/8
2/8
3/8
4/8
5/8
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH tip/core/rcu 0/8] RCU callback-numbering simplifications for 3.11

Hello!

This series takes advantage of callback numbering to simplify RCU's grace-period machinery, in some cases also reducing the number of lock acquisitions (though the resulting change in performance is not perceptible). The individual patches are as follows:

1. Move code to make way for the code-combining in later patches.
This commit makes no changes, just moves code.

2. Make __note_new_gpnum() also check for the ends of prior grace
periods, thus eliminating the earlier possibility of a given CPU becoming aware of the start of the next grace period before becoming aware of the end of the previous grace period. Yes, the code did handle this correctly, but now it doesn't need to. More important, now I don't need to think about how it handles this correctly.

3. Rename note_new_gpnum() to note_gp_changes() in preparation for
later merge of rcu_process_gp_end() into this function.

4. Change calls to rcu_process_gp_end() to instead call
note_gp_changes(), and also remove the now-used rcu_process_gp_end().

5. Remove duplicate code by merging __rcu_process_gp_end() into

	__note_gp_changes().

6. Eliminate now-redundant call to check_for_new_grace_period(). This
leaves only a single caller, so inline check_for_new_grace_period().

7. Given that rcu_start_gp_per_cpu() is a trivial wrapper function
with only one caller, inline it into its sole remaining call site.

8. Eliminate now-redundant call to note_gp_changes().

Thanx, Paul

 b/kernel/rcutree.c        |  262 ++++++++++++++--------------------------------
 b/kernel/rcutree_plugin.h |    2 
 2 files changed, 85 insertions(+), 179 deletions(-)