Skip to content

(Was: kernel: move exit_task_work() past exit_notify())

Oleg Nesterov lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1move exit_task_namespaces() outside of exit_notify()kernel/exit.c+1 -15 replies

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

PatchEric W. BiedermanAndrew VaginAndrey Vagin
1/1A-b A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/1] (Was: kernel: move exit_task_work() past exit_notify())
Quoted 19 lines · Oleg Nesterov
Quoted 12 lines
kernel/exit.c +0 -1
@@ -795,7 +795,6 @@ void do_exit(long code)
 	exit_shm(tsk);
 	exit_files(tsk);
 	exit_fs(tsk);
-	exit_task_work(tsk);
 	check_stack_usage();
 	exit_thread();
 

kernel/exit.c void do_exit(long code) · line 824

Quoted 4 lines
kernel/exit.c +1 -0
@@ -822,6 +821,7 @@ void do_exit(long code)
 	ptrace_put_breakpoints(tsk);
 
 	exit_notify(tsk, group_dead);
+	exit_task_work(tsk);

I am not comfortable with this change...

Quoted 4 lines

The task is "really dead" after exit_notify(), even release_task(current) can be called.

Let me think a bit... It seems that we have the alternative.

Andrey, Eric, how about this patch?

COMPLETELY UNTESTED and I need to recheck, but perhaps you can review?

Oleg.