Skip to content

kill ptrace_{get,put}_breakpoints()

Oleg Nesterov lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5ptrace/x86: Revert "hw_breakpoints: Fix racy access to ptrace breakpoints"arch/x86/kernel/ptrace.c+5 -232 replies
2/5ptrace/powerpc: Revert "hw_breakpoints: Fix racy access to ptrace breakpoints"arch/powerpc/kernel/ptrace.c+0 -200 replies
3/5ptrace/arm: Revert "hw_breakpoints: Fix racy access to ptrace breakpoints"arch/arm/kernel/ptrace.c+0 -81 reply
4/5ptrace/sh: Revert "hw_breakpoints: Fix racy access to ptrace breakpoints"arch/sh/kernel/ptrace_32.c+0 -40 replies
5/5ptrace: Revert "Prepare to fix racy accesses on task breakpoints"include/linux/ptrace.h include/linux/sched.h kernel/exit.c +1 more+1 -301 reply

Reviews trailers per patch

3 of 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchIngo MolnarFrederic WeisbeckerMichael NeulingWill Deacon
SeriesA-b A-b
1/5A-b A-b
2/5
3/5A-b
4/5
5/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 0/5] kill ptrace_{get,put}_breakpoints()

Hello.

Kill ptrace_{get,put}_breakpoints and task_struct->ptrace_bp_refcnt, 9899d11f "ptrace: ensure arch_ptrace/ptrace_request can never race with SIGKILL" made this all unneeded.

Benjamin, Paul, arch_dup_task_struct()->flush_ptrace_hw_breakpoint(src) on powerpc looks "obviously wrong". Don't we need

- flush_ptrace_hw_breakpoint(src);
+ dst->thread->ptrace_bps[0] = NULL;

?

Oleg.