Skip to content

ARM: Kirkwood: Add DT support for (eSATA) Sheevaplug

Andrew Lunn linux-arm-kernel linux-mmc 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 of 3 patches 0 repliesNew

2 of 3 patches are in this archive. The cover letter announces 3.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3mmc: mvsdio: Support inverted CD and WP GPIO lines+0 -01 reply
1/3mmc: mvsdio: Support inverted CD and WP GPIO lines+0 -04 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] ARM: Kirkwood: Add DT support for (eSATA) Sheevaplug
Quoted 19 lines · Simon Baatz

These patches add DT support for the Sheevaplugs by Globalscale Technologies. There exists two versions, one with an eSATA port and one without.

Surprisingly, the conversion was not straight forward. In the eSATA version (board revision 1.3), the CD and WP pins are connected to GPIO lines, but I could not get this to work. Apparently, I am not the only one ([1]). I found that the pins are reversed on my hardware and use different active low/active high settings.

Thus, the first patch adds support for the GPIO active low/high flag in DT to the mvsdio driver.

With that, everything except the Gigabit Ethernet can be described in the DTS. I have split the DTS and the board support files into two patches. This way, we can drop the last patch once we can describe everything in the DTS or we can squash them together if we don't want to wait.

Quoted 6 lines

I could only test on an eSATA Sheevaplug. I found patches with different LEDs for the Sheevaplug. Thus, I would highly appreciate if someone with the hardware could give this a spin on a non-eSATA version. Some additional testing of the change detect and write protect behaviour for sdio can't hurt either. I hope that there aren't board revisions with different CD/WP pins out there.

Hi Simon

Patches 2 and 3 look good to me. If you submit a new version with the SDIO issue resolved i can give you a Acked-by:

Thanks
Andrew