Skip to content

Convert all to the caller hold lock version

Wang YanQing lkml 1 version In review

Get series with b4
b4 am 20130508181304.GA12344@udknight

Versions newest first

  1. v1 Latest9 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9fbcon: convert last fbcon_takeover call to do_fbcon_takeoverdrivers/video/console/fbcon.c+2 -10 replies
2/9fbcon: delete unneeded function fbcon_takeoverdrivers/video/console/fbcon.c+0 -280 replies
3/9vt: delete unneeded functions register_con_driver|take_over_consoledrivers/tty/vt/vt.c include/linux/console.h+0 -477 replies
4/9vt: convert last unbind_con_driver call to do_unbind_con_driverdrivers/tty/vt/vt.c+5 -20 replies
5/9vt: delete unneeded function unbind_con_driverdrivers/tty/vt/vt.c include/linux/vt_kern.h+0 -300 replies
6/9vt: convert last bind_con_driver call to do_bind_con_driverdrivers/tty/vt/vt.c+5 -20 replies
7/9vt: delete unneeded function bind_con_driverdrivers/tty/vt/vt.c+0 -110 replies
8/9fbcon: convert last two unregister_con_driver call to do_unregister_con_driverdrivers/tty/vt/vt.c drivers/video/console/fbcon.c+4 -20 replies
9/9vt: delete unneeded function unregister_con_driverdrivers/tty/vt/vt.c include/linux/console.h+1 -130 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/9] Convert all to the caller hold lock version

After commit 50e244cc793d511b86adea24972f3a7264cae114
(fb: rework locking to fix lock ordering on takeover)
and
commit e93a9a868792ad71cdd09d75e5a02d8067473c4e (fb: Yet another band-aid for fixing lockdep mess)

We have two version functions implement almost the same function, except the caller/callee hold lock.

fbcon_takeover vs do_fbcon_takeover
register_con_driver vs do_register_con_driver
take_over_console vs do_take_over_console
unbind_con_driver vs do_unbind_con_driver
bind_con_driver vs do_bind_con_driver
unregister_con_driver vs do_unregister_con_driver

This issue bring us much code duplication,
like do_fbcon_takeover and fbcon_takeover,
they have almost the same.

Although some of them had been re-written
as a wrapper for another, but the wrapper
is so trivial, we can just throw them away.

Also those two versions of almost the same
functions will confuse API's user.

After all, I think this issue is not good
for long time maintain.

This series patch convert all to the
new version which caller hold the lock,
and then delete the old version away.

Thanks