clk: implement remuxing during set_rate
Get series with b4
b4 am 20130514221525.10068.86581@quantumVersions newest first · linked by author and title
- v2 Latest posting 2/20 of 3 patches 0 repliesNew
- v2 posting 1/20 of 3 patches 1 replySuperseded
Patches in v2 posting 2/2 No applies recorded yet
None of the 3 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 0/3] clk: implement remuxing during set_rate
Quoting James Hogan (2013-05-14 14:01:18)
Quoted 19 lines
Hi Mike,
Quoted 16 lines · Mike Turquette
Quoting James Hogan (2013-05-13 14:30:46)
Quoted 9 lines · Mike Turquette
Quoted 2 lines
One reason for this is the difficulty some have had with setting flags from DT bindings.
Could you elaborate on this? I've been adding flags to DT bindings for this sort of thing, but it feels a bit like it's in that grey area of not really describing the hardware itself. This information needs to be specified somehow though.
It depends on the flag. A good example is the
CLK_DIVIDER_ONE_BASEDflag which does describe the hardware. It informs the binding that indexing starts at 1, not 0, which is a valid part of the hardware description.
Quoted 9 lines
Quoted 5 lines
However flags that deal with software policy do not belong on DT.
CLK_SET_RATE_PARENTcertainly does not belong in the DT binding since this is a pure Linux-ism. Every binding just needs to be reviewed on a case-by-case basis to make sure the flags are related only to the hardware.So given the desire to eliminate platform code, is there a particular way that these other flags can be specified instead of DT bindings?
I haven't put too much thought into this. There have been many discussions lately about where to put configuration data, which would include the "policy" flags. Some folks have discussed using DT, but keeping the config data separate from the hardware description data (one thread I read called the idea "config tree"). Examples of this are setting parents for mux clocks, or setting clock rates at boot-time. This data is important, but it is a configuration of the hardware. Not a description of it.
Anyways it is a general problem, so I'm hoping someone will find a general solution. For now I've seen a couple instance of clock drivers including clk-private.h to modify the flags at registration time, which is beyond horrible. But again those users may not have a better option, short of a new clk_set_flags() function, which is also horrible.
Regards,
Mike
Quoted 2 lines
Cheers
James