Marvell PCIe driver improvements
Get series with b4
b4 am 20130523205726.05ba45bf@skateVersions newest first
- v1 Latest0 of 4 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 4 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/4] Marvell PCIe driver improvements
Dear Jason Gunthorpe,
Quoted 8 lines · Jason Gunthorpe
Quoted 7 lines
FWIW, these patches applied on top of your pcie-v10 tree have made my mini-pcie dual-nic appear for the first time on the mirabox. Till now I never knew if it was a hardware or software issue since the NIC does not appear in u-boot nor lspci, whatever the kernel versions, including the original Marvell one's. The NIC has two functions (one per controller) and no bridge, so it may be a side effect of your improvements (or maybe you fixed a bug).
Quoted 4 lines
There was some talk earlier that some buggy chips required their device number to be 0. I'm guessing Thomas's change to ensure that always happens by moving the device number of the internal device is the root fix here?
You're correct. Off-list, I've sent to Willy a patch that applies on top of those additional "bridge-related" fixes, but that reverts back the slot number of the real PCIe device to be 1 instead of 0. And in this case, the PCIe device that Willy is using is not detected.
So indeed, there are some PCIe devices who really want to receive "configuration transactions" as slot 0.
Best regards,
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com