Skip to content

Fix Marvell mv63xxx I2C driver

Wolfram Sang linux-arm-kernel linux-i2c 1 version New

Get series with b4
b4 am 20130605214822.GE2934@katana

Versions newest first

  1. v1 Latest3 of 9 patches 0 repliesNew

3 of 9 patches are in this archive. The cover letter announces 9.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9I2C: mv64xxx: work around signals causing I2C transactions to be aborted+0 -00 replies
9/9I2C: mv64xxx: fix race between FSM/interrupt and process context+0 -01 reply
9/9I2C: mv64xxx: fix race between FSM/interrupt and process context+0 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/9] Fix Marvell mv63xxx I2C driver
Quoted 9 lines · Russell King - ARM Linux

This patch series fixes a whole chunk of problems with this driver, discovered with the Marvell Armada 510 chip on the Solid-run cubox.

Most notable of these is the I2C driver aborting a transaction because a signal is pending - which might be SIGPIPE or SIGALRM for the process. Meanwhile, the calling driver may be in the middle of a critical read-modify-write cycle on a device register, causing it to fail.

Quoted 6 lines

Other problems are race conditions in the handling of multi-part messages, where we end up sending multiple start conditions - sometimes more times than we have i2c_msg's to send.

Lastly is the rather poor probe error handling, which ranges from non-existent to lacking propagating the provided error code.

Applied rest of the series to for-next, thanks!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130605/32e7753b/attachment.sig>