Skip to content

de_thread() should update ->real_start_time

Oleg Nesterov lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3de_thread: mt-exec should update ->real_start_timefs/exec.c+1 -00 replies
2/3uptime_proc_show: use get_monotonic_boottime()fs/proc/uptime.c+1 -20 replies
3/3do_sysinfo: use get_monotonic_boottime()kernel/sys.c+1 -20 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJohn Stultz
SeriesA-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] de_thread() should update ->real_start_time

1/3 is the obvious bugfix, 2 and 3 are minor cleanups

I am wondering, can't we kill task->real_start_time? What if we simply change copy_process

	-	do_posix_clock_monotonic_gettime(&p->start_time);
	+	get_monotonic_boottime(&p->start_time);

?

Afaics, this will only affect do_acct_process() and bacct_add_tsk(), but do we really want to exclude the suspended time in this case?

Another user of ->start_time is cgroup.c and it looks wrong... But the change above should not make any difference.

Oleg.