Skip to content

net: low latency sockets follow ups

Eliezer Tamir lkml netdev 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest4 patches 1 replyIn review
  2. v44 patches 3 repliesSuperseded
  3. v34 patches 3 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v23 patches6 repliesSuperseded
v12 patches10 repliesSuperseded

Change log from the cover letter

v5
- use time_after64() instead of time_after, suggested by Eric Dumazet.

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4net: change sysctl_net_ll_poll into an unsigned intinclude/net/ll_poll.h net/core/sysctl_net_core.c net/socket.c+6 -50 replies
2/4net: convert low latency sockets to sched_clock()include/net/ll_poll.h net/Kconfig+17 -170 replies
3/4net: remove NET_LL_RX_POLL config menuenet/Kconfig+2 -90 replies
4/4net: add socket option for low latency pollingarch/alpha/include/uapi/asm/socket.h arch/avr32/include/uapi/asm/socket.h arch/cris/include/uapi/asm/socket.h +16 more+58 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [PATCH v5 net-next 0/4] net: low latency sockets follow ups

David,

Here are three clean up patches, plus one that adds a socket option for LLS.

Patch 1 converts sysctl_net_ll_poll into an unsigned int
Patch 2 converts low latency sockets to sched_clock.
Patch 3 removes the config menu for NET_LL_RX_POLL and defaults to y. Patch 4 adds an SO_LL socket option to allow per-socket control of busy polling.

I will reply to this thread with a patch to sockperf that enables the socket option. (unchanged from v2)

Again, thanks to everyone for their comments.

-Eliezer

Change log:
v5
- use time_after64() instead of time_after, suggested by Eric Dumazet.

v4
- Fixed possible overflow, pointed out by Eric Dumazet. (reordered the patches)

v3
- Suggested by David Miller and Stephen Hemminger:
added a patch to covert from get_cycles() to sched_clock(), remove dependency on X86_TSC.
- Suggested by Eric Dumazet:
un-exported sysctl_net_ll_poll since for now it's not needed in modules.

v2
- added a patch to convert sysctl_net_ll_poll into an unsigned int.
- suggested by Eric Dimazet: treat sk_ll_usec as a u_int rather than a u_long.
- suggested by Ben Huchings: allow unprivileged user to decrease SO_LL value, correct return value when operation is not allowed.

Read the cover letter in its thread