Skip to content

tracing/kprobes: trace_probe->files cleanups

Oleg Nesterov lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3tracing/kprobes: Avoid perf_trace_buf_*() if ->perf_events is emptykernel/trace/trace_kprobe.c+8 -43 replies
2/3tracing/kprobes: Kill probe_enable_lockkernel/trace/trace_kprobe.c+10 -239 replies
3/3tracing/kprobes: Turn trace_probe->files into list_headkernel/trace/trace_kprobe.c+37 -1012 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchMasami Hiramatsu
1/3A-b
2/3A-b A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] tracing/kprobes: trace_probe->files cleanups

Hello.

I simply can't understand why trace_kprobe.c uses "struct ftrace_event_file **", the simple list_head looks much more natural and simple.

And we do not want to copy-and-paste this code to trace_uprobe.c. If there is a reason for array-of-pointers we should create the helpers in the common trace_probe.c so that uprobes can use them too.

Oleg.

 kernel/trace/trace_kprobe.c |  171 ++++++++++++------------------------------
 1 files changed, 49 insertions(+), 122 deletions(-)