Kernel mode NEON for XOR and RAID6
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest0 of 5 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 5 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/5] Kernel mode NEON for XOR and RAID6
Hi guys,
Quoted 10 lines · Nicolas Pitre
Quoted 7 lines · Will Deacon
Quoted 4 lines
Note that the kernel performs runtime benchmarking of all the different implementations it has available at boot time and selects the best one. So if this would turn out to make things worse on some cores then the Neon code would simply not be used.
That will be all sorts of fun if we try to run this on big.LITTLE... Perhaps we don't care about that either.
Probably not at the present time.
[...]
Quoted 5 lines
Quoted 4 lines
What's the earliest toolchain we claim to support nowadays? If that can't deal with the intrinsics then we either need to bump the requirement, or write this using hand-coded asm. In the case of the latter, I don't think the maintenance overhead of having two implementations is worth it.
Quoted 8 lines
We have many different minimum toolchain version requirements attached to different features being enabled already, ftrace being one of them if I remember correctly. For these Neon optimizations the minimum gcc version is v4.6.
Given that this is going to be interesting mostly to server systems, and given that ARM server deployments are rather new, I don't see the point of compiling a new server environment using an older gcc version.
I've mulled over this, had some discussions with our toolchain guys and have concluded the following:
- The intrinsics are actually ok. I was sceptical at first, but I've been assured that they should do a reasonable job (echoing your performance figures).
- The current approach is targetting servers and isn't (yet) suitable for mobile.
So, given that the patches do the right thing wrt GCC version, the only remaining point is that we need to keep an eye out for people trying to re-use this stuff for mobile (likely crypto, as I mentioned earlier). When that happens, we should consider revisiting the benchmark/power figures.
Will