Skip to content

Final Samsung PWM support cleanup

Arnd Bergmann linux-arm-kernel linux-pwm linux-samsung-soc 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest0 of 18 patches 0 repliesNew

Patches in v2 No applies recorded yet

None of the 18 patches the cover letter announces are in this archive.

Reviews trailers per patch

PatchArnd Bergmann
SeriesA-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/18] Final Samsung PWM support cleanup
Quoted 17 lines · Tomasz Figa

Since we now have a proper Samsung PWM clocksource driver in place, we can proceed with further cleanup of PWM timers support on Samsung SoCs.

This series attempts to achieve this goal by:
1) moving remaining Samsung platforms to the new clocksource driver
2) removing old clocksource driver
3) adding new multiplatform- and DT-aware PWM driver
4) moving all Samsung platforms to use the new PWM driver
5) removing old PWM driver
6) removing all PWM-related code that is not used anymore

Cleaning up the PWM driver is a bit tricky, because the design of current driver makes it completely unsuitable for DT and multiplatform and would require a heavy rework to make it usable, breaking any existing Samsung PWM users by the way. To avoid any breakage I decided to keep the old driver, add new one, move all platforms to it and then remove the old one.

Quoted 7 lines

See particular patches for more detailed descriptions.

On S3C6410-based Tiny6410 (Mini6410-compatible), after enabling pwm-beeper and Exynos4210-based Origen board (with PWM0 attached to a scope):

Looks good to me,

Two small comments:

* always use 'git format-patch -M' to detect renames (patch 10)

* for new code, don't use __raw_readl and similar functions but use readl_relaxed or plain readl.

Arnd