Skip to content

add a pseudo pps limit to netback

William Dauchy xen-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 5 repliesIn review
  2. v33 patches 8 repliesSuperseded
  3. v21 patch 3 repliesSuperseded

Changes in v4 from the cover letter

- fix toolstack memleak
Ahmed Amamou (1):
xen netback: add a pseudo pps rate limit

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3xen netback: add a pseudo pps rate limitdrivers/net/xen-netback/common.h drivers/net/xen-netback/interface.c drivers/net/xen-netback/netback.c +1 more+72 -71 reply
2/3handle pps limit parametertools/libxl/libxl.c tools/libxl/libxl_types.idl tools/libxl/libxlu_vif.c+71 -32 replies
3/3netif documentationdocs/misc/xl-network-configuration.markdown xen/include/public/io/netif.h+40 -51 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/3][xen-netback][toolstack] add a pseudo pps limit to netback

VM traffic is already limited by a throughput limit, but there is no control over the maximum packet per second (PPS).
In DDOS attack the major issue is rather PPS than throughput. With provider offering more bandwidth to VMs, it becames easy to coordinate a massive attack using VMs. Example: 100Mbits ~ 200kpps using 64B packets.
This patch provides a new option to limit VMs maximum packets per second emission rate.
It follows the same credits logic used for throughput shaping. For the moment we have considered each "txreq" as a packet.
PPS limits is passed to VIF at connection time via xenstore. PPS credit uses the same usecond period used by rate shaping check.

known limitations:
- by using the same usecond period, PPS shaping depends on throughput shaping.
- it is not always true that a "txreq" correspond to a paquet (fragmentation cases) but as this shaping is meant to avoid DDOS (small paquets) such an pproximation should not impact the results.
- Some help on burst handling will be appreciated.

v2:
- fix some typo

v3:

- fix some typo
- add toolstack patch

v4:
- fix toolstack memleak
Ahmed Amamou (1):
xen netback: add a pseudo pps rate limit

 drivers/net/xen-netback/common.h    |    2 ++
 drivers/net/xen-netback/interface.c |    1 +
 drivers/net/xen-netback/netback.c   |   41 +++++++++++++++++++++++++++++++++++
 drivers/net/xen-netback/xenbus.c    |   31 +++++++++++++++++++++-----
 4 files changed, 70 insertions(+), 5 deletions(-)

[toolstack]
This patch will update the libxl in order to provide the new pps limit new pps limit can be defined as follow
YYMb/s&XXKpps@ZZms
or
YYMb/s@ZZms&XXKpps
or
YYMb/s&XXKpps in such case default 50ms interval will be used

Ahmed Amamou (2):
handle pps limit parameter
netif documentation

 docs/misc/xl-network-configuration.markdown |   18 +++++--
 tools/libxl/libxl.c                         |    3 ++
 tools/libxl/libxl_types.idl                 |    1 +
 tools/libxl/libxlu_vif.c                    |   70 +++++++++++++++++++++++++--
 xen/include/public/io/netif.h               |   27 +++++++++++
 5 files changed, 111 insertions(+), 8 deletions(-)
Signature · 1 line
1.7.9.5