Skip to content

clocksource: sunxi: Timer fixes and cleanup

Siarhei Siamashka linux-arm-kernel lkml 1 version In review

Get series with b4
b4 am 20130628132912.014b2f5b@i7

Versions newest first

  1. v1 Latest0 of 8 patches 1 replyIn review

Patches in v1 No applies recorded yet

None of the 8 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [linux-sunxi] [PATCH 0/8] clocksource: sunxi: Timer fixes and cleanup
Quoted 24 lines · On Fri, 28 Jun 2013 09:43:37 +0800 ?? <[email protected]> wrote:
Quoted 12 lines

The A10 manual from http://free-electrons.com/~maxime/pub/datasheet/
does not seem to contain any details about what bad things may happen if we try to read CNT64_LO_REG while latching is still in progress and CNT64_RL_EN bit in CNT64_CTRL_REG has not changed to zero yet. I can imagine the following possible scenarios:
1. We read either the old stale CNT64_LO_REG value or the new correct value.
2. We read either the old stale CNT64_LO_REG value or the new correct value, or some random garbage.
3. The processor may deadlock, eat your dog, or do some other nasty thing.

Quoted 1 line

In the case of 1, we probably can get away without using any spinlocks?

About the 64bits counter, the latch bit is needed because of the asynchronous circuit. The internal circuit of 64bits counter is working under 24Mhz clock, and CNT_LO/HI is read with APB clock. So the clock synchronize is needed. The function of the latch is synchronous the 64bits counter from 24Mhz clock domain to APB clock domain. So, if the latch is not completely, value of the CNT_LO/HI maybe a random value, because some bits are latched, but others are not. So, the CNT_LO/HI should be read after latch is completely. The latch just takes 3 cycles of 24Mhz clock, the time is nearly 0.125 micro-second.

[...]

Quoted 1 line

NOTICE: This e-mail and any included attachments are intended only for the sole use of named and intended recipient (s) only. If you are the named and intended recipient, please note that the information contained in this email and its embedded files are confidential and privileged. If you are neither the intended nor named recipient, you are hereby notified that any unauthorized review, use, disclosure, dissemination, distribution, or copying of this communication, or any of its contents, is strictly prohibited. Please reply to the sender and destroy the original message and all your records of this message (whether electronic or otherwise). Furthermore, you should not disclose to any other person, use, copy or disseminate the contents of this e-mail and/or the documents accompanying it.

Ugh, just spotted this at the bottom.

I believe that by sending this information to LKML and the other public mailing lists, the intended recipient is "the whole world", hence most of the stated clauses (for example related to "any other person") can be safely optimized out. Still this does not sound very nice. I hope that the original intention was to authorize sharing and using this information. Please correct me if I'm wrong.

Signature · 2 lines
Best regards,
Siarhei Siamashka