Skip to content

RFC Cleanup PRM and CM regbit headers

Tony Lindgren linux-arm-kernel linux-omap 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest0 of 4 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 4 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 0/4] Cleanup PRM and CM regbit headers
Quoted 19 lines · Rajendra Nayak
Quoted 5 lines · Paul Walmsley

You mentioned that these patches were generated with some kind of awk/grep scripting. Can you integrate that in an automated way into the autogeneration flow? If the answer is yes, then keep the header. If the answer is no, then the header should be dropped. Beno?t, maybe you have an opinion too?

Ok, I'll try and integrate those scripts so all this can be done in an automated way even for newer SoCs.

Quoted 8 lines

As far as whether this should go in -rcX or not, my view is that, as a matter of policy, large changes like this should wait until v3.12. Now, having written that, I also was under the impression that the OMAP5 changes weren't going to be sent upstream unless the total diffstat would be balanced to roughly zero or negative lines. As far as I know, that didn't happen. So I guess, v3.11-rc it is... kernel development by diffstat :-(

Quoted 1 line

I don't mind these going in -rcX or 3.12, either way is fine.

Removal of unused code should be OK for the early -rc. I doubt that anybody would object it especially considering that's it's a huge pile of unused defines that most likely won't ever be needed for DT based booting.

Quoted 9 lines
Quoted 4 lines

Finally, please repost the whole series once you're done with your changes, as a non-RFC, along with your pull request (if you plan to send one). I guess I should be the one to take these, since I wound up taking the OMAP5 addition...

:) I thought so too that you should be the one sending the pull. I will post these out as non-RFC after I do a clean integration into the autogen scripts, and then you can take a call on sending the pull for either -rcX or 3.12

I'd prefer to have it done now for the early -rc series. But if it drags on, we should not merge it during the -rc series.

Regards,

Tony