Skip to content

virtio/console: Fix two bugs of splice_write

Yoshihiro YUNOMAE virtualization 4 versions – New

Get series with b4
b4 am '20130722040043.7531.78801.stgit__17435.1942529485$1374465426$gmane$org@yunodevel'

Versions newest first · linked by author and title

  1. v3 Latest posting 2/20 of 2 patches 0 repliesNew
  2. v3 posting 1/22 patches 4 repliesSuperseded
  3. v22 patches 5 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches5 repliesSuperseded

Changes in v3 from the cover letter

- Add Reviewed-by lines and stable@ line in sign-off area

Patches in v3 posting 2/2 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH V3 0/2] [BUGFIX] virtio/console: Fix two bugs of splice_write

Hi,

This patch set fixes two bugs of splice_write in the virtio-console driver.

[BUG1] Although pipe->nrbufs is empty, the driver tries to do splice_write.
=> This induces oops in sg_init_table().

[BUG2] No lock for competition of splice_write.
=> This induces oops in splice_from_pipe_feed() by bug of any user
application.

These reports are written in each patch.

Changes in V2:
- Fix a locking problem for error

Changes in V3:
- Add Reviewed-by lines and stable@ line in sign-off area

Thanks!

---

Yoshihiro YUNOMAE (2):
[BUGFIX] virtio/console: Quit from splice_write if pipe->nrbufs is 0 [BUGFIX] virtio/console: Add pipe_lock/unlock for splice_write

 drivers/char/virtio_console.c |   23 ++++++++++++++++++++---
 1 file changed, 20 insertions(+), 3 deletions(-)
Signature · 4 lines
Yoshihiro YUNOMAE
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: [email protected]