tracing: open/delete fixes
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest6 patches 13 repliesIn review
- v16 patches 14 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | tracing: Turn event/id->i_private into call->event.typekernel/ | +12 | 1 reply | |
| 2/6 | tracing: Change event_enable/disable_read() to verify i_private != NULLkernel/ | +20 | 2 replies | |
| 3/6 | tracing: Change event_filter_read/write to verify i_private != NULLkernel/ kernel/ | +25 | 1 reply | |
| 4/6 | tracing: Change f_start() to take event_mutex and verify i_private != NULLkernel/ | +9 | 1 reply | |
| 5/6 | tracing: Introduce remove_event_file_dir()kernel/ | +23 | 1 reply | |
| 6/6 | tracing: Change remove_event_file_dir() to clear "d_subdirs"->i_privatekernel/ | +9 | 7 replies |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | Masami Hiramatsu |
|---|---|
| 1/6 | R-b |
| 2/6 | R-b |
| 3/6 | R-b |
| 4/6 | R-b |
| 5/6 | R-b |
| 6/6 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/6] tracing: open/delete fixes
Hello.
Testing: seems to work, but assumes that debugs was fixed too. Hopefully "debugfs: debugfs_remove_recursive() must not rely on list_empty(d_subdirs)" is fine.
(We should probably make debugfs_remove_recursive() to return the error
and trace_events.c should warn if it fails)
However: I am still testing this patches, so this is still mostly for review. I'll report if I find anything, but to remind we have other bugs which need more fixes. And in fact I need to re-read this series to convince myself it should work, I was distracted by the unexpected problem in debugfs.
Changes: a lot but all cosmetic, addresses the comments from Steven.
Steven, 1/6 was not changed, I assume you agreed with my reply.
Masami, I'll appreciate your review ;)
Oleg.
kernel/trace/trace_events.c | 155 +++++++++++++++++++----------------- kernel/trace/trace_events_filter.c | 17 ++--- 2 files changed, 87 insertions(+), 85 deletions(-)