tracing: trace_remove_event_call() should fail if call/file is in use
Get series with b4
b4 am [email protected]Versions newest first
- v2 Latest1 patch 6 repliesIn review
Changes from the cover letter
- remove the TRACE_EVENT_FL_REF_MASK (which we do not have) check.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/1 | tracing: trace_remove_event_call() should fail if call/file is in useinclude/ kernel/ | +34 | 3 replies |
Reviews trailers per patch
The patch has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Masami Hiramatsu |
|---|---|
| Series | A-b |
| 1/1 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/1] tracing: trace_remove_event_call() should fail if call/file is in use
Hello.
On top of "[PATCH v2 0/6] tracing: open/delete fixes" series.
Perhaps this series should be updated, Masami has some concerns. But it seems that you both mostly agree with these changes, so let me send the "last" patch for review.
The last change in kernel/trace/trace_events.c we need to close the problems with create/use/delete (at least those which I know ;).
Now we are ready to change trace_kprobe.c and trace_uprobe.c, Steven already has the patches.
Changes:
- remove the TRACE_EVENT_FL_REF_MASK (which we do not have) check.
We rely on the previous changes, we do not care if someone have an opened file, event_enable_write/etc can do nothing but fail after we do remove_event_file_dir().
- Add the comment and a note into the changelog to explain why we still need to check FTRACE_EVENT_FL_ENABLED.
Oleg.
include/linux/ftrace_event.h | 2 +- kernel/trace/trace_events.c | 35 +++++++++++++++++++++++++++++++++-- 2 files changed, 34 insertions(+), 3 deletions(-)