Skip to content

ftrace/tracing: Event file fixes and ftrace function hash fixes

Steven Rostedt lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8tracing: Turn event/id->i_private into call->event.typekernel/trace/trace_events.c+13 -50 replies
2/8tracing: Change event_enable/disable_read() to verify i_private != NULLkernel/trace/trace_events.c+20 -100 replies
3/8tracing: Change event_filter_read/write to verify i_private != NULLkernel/trace/trace_events.c kernel/trace/trace_events_filter.c+25 -180 replies
4/8tracing: Change f_start() to take event_mutex and verify i_private != NULLkernel/trace/trace_events.c+9 -40 replies
5/8tracing: Introduce remove_event_file_dir()kernel/trace/trace_events.c+23 -240 replies
6/8tracing: Change remove_event_file_dir() to clear "d_subdirs"->i_privatekernel/trace/trace_events.c+15 -320 replies
7/8ftrace: Consolidate some duplicate code for updating ftrace opskernel/trace/ftrace.c+10 -60 replies
8/8ftrace: Clear module traced functions on unload modulekernel/trace/ftrace.c+60 -01 reply

Reviews trailers per patch

6 of 8 patches have a Reviewed-by or Acked-by.

PatchMasami HiramatsuSteve Hodgson
1/8R-b
2/8R-b
3/8R-b
4/8R-b
5/8R-b
6/8R-b
7/8
8/8T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [for-next-3.11][PATCH 0/8] ftrace/tracing: Event file fixes and ftrace function hash fixes

Oleg has been continuing his work on fixing a race between opening an event file and deleting that same event. Using the i_private and event_mutex to verify that the event still exists to solve the race.

A long standing bug on the ftrace hash accounting has finally been figured out. When tracing a module that is removed and then reloaded, the function filter hash gets out of sync with the function record's ref count which causes a nasty warning and disabling of the function tracer.

git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
for-next

Head SHA1: 6fd52fce057b55cc1bba463e6f05536a76c058b4

Oleg Nesterov (6):

      tracing: Turn event/id->i_private into call->event.type
      tracing: Change event_enable/disable_read() to verify i_private != NULL
      tracing: Change event_filter_read/write to verify i_private != NULL
      tracing: Change f_start() to take event_mutex and verify i_private != NULL
      tracing: Introduce remove_event_file_dir()
      tracing: Change remove_event_file_dir() to clear "d_subdirs"->i_private

Steven Rostedt (Red Hat) (2):
ftrace: Consolidate some duplicate code for updating ftrace ops
ftrace: Clear module traced functions on unload module

----

 kernel/trace/ftrace.c              |   76 +++++++++++++++--
 kernel/trace/trace_events.c        |  159 ++++++++++++++++++++----------------
 kernel/trace/trace_events_filter.c |   17 ++--
 3 files changed, 164 insertions(+), 88 deletions(-)