Skip to content

POWER/cpuidle: Generic POWERPC-BOOK3S cpuidle driver enabled for PSERIES and POWERNV platforms

Deepthi Dharwar linuxppc-dev lkml 7 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest7 patches 0 repliesNew
  2. v77 patches 10 repliesSuperseded
  3. v67 patches 0 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v55 patches3 repliesSuperseded
v45 patches2 repliesSuperseded
v3 RFC5 patches10 repliesSuperseded
v26 patches9 repliesSuperseded

Changes in v8 from the cover letter

============
* Renaming driver and related files from ibm-power-idle to powerpc-book3s-idle
for clarity and to avoid confusing between ibm-power systems and power mgmt.

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7pseries/cpuidle: Move processor_idle.c to drivers/cpuidle.arch/powerpc/include/asm/processor.h arch/powerpc/platforms/pseries/Kconfig arch/powerpc/platforms/pseries/Makefile +5 more+384 -3750 replies
2/7pseries/cpuidle: Use cpuidle_register() for initialisation.drivers/cpuidle/cpuidle-powerpc-book3s.c+12 -680 replies
3/7pseries/cpuidle: Make pseries_idle backend driver a non-module.drivers/cpuidle/cpuidle-powerpc-book3s.c+1 -140 replies
4/7pseries/cpuidle: Remove MAX_IDLE_STATE macro.drivers/cpuidle/cpuidle-powerpc-book3s.c+9 -170 replies
5/7POWER/cpuidle: Generic POWERPC-BOOK3S CPUIDLE driver supporting PSERIES.drivers/cpuidle/cpuidle-powerpc-book3s.c+16 -160 replies
6/7POWER/cpuidle: Enable powernv cpuidle support.drivers/cpuidle/cpuidle-powerpc-book3s.c+36 -30 replies
7/7powernv/cpuidle: Enable idle powernv cpu to call into the cpuidle framework.arch/powerpc/platforms/powernv/setup.c+12 -10 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchDaniel Lezcano
1/7A-b
2/7A-b
3/7A-b
4/7A-b
5/7A-b
6/7A-b
7/7A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v8 thread

Cover letter [PATCH v8 0/7] POWER/cpuidle: Generic POWERPC-BOOK3S cpuidle driver enabled for PSERIES and POWERNV platforms

This patch series consolidates the backend cpuidle driver for pSeries and powernv platforms with minimal code duplication.

Current existing backend driver for pseries has been moved to drivers/cpuidle and has been extended to accommodate powernv idle power mgmt states. As seen in V1 of this patch series, having a separate powernv backend driver results in too much code duplication, which is less elegant and can pose maintenance problems going further.

Using the cpuidle framework to exploit platform low power idle states management can take advantage of advanced heuristics, tunables and features provided by framework. The statistics and tracing infrastructure provided by the cpuidle framework also helps in enabling power management related tools and help tune the system and applications.

Earlier in 3.3 kernel, pSeries idle state management was modified to exploit the cpuidle framework and the end goal of this patch is to have powernv platform also to hook its idle states into cpuidle framework with minimal code duplication between both platforms.

This series aims to maintain compatibility and functionality to existing pseries and powernv idle cpu management code. There are no new functions or idle states added as part of this series. This can be extended by adding more states to this existing framework.

With this patch series, the powernv cpuidle functionalities are on-par with pSeries idle management.

V1 -> http://lkml.org/lkml/2013/7/23/143
V2 -> https://lkml.org/lkml/2013/7/30/872
V3 -> http://comments.gmane.org/gmane.linux.ports.ppc.embedded/63093
V4 -> https://lkml.org/lkml/2013/8/22/25
V5 -> http://lkml.org/lkml/2013/8/22/184
V6 -> https://lkml.org/lkml/2013/8/27/432
v7 -> https://lkml.org/lkml/2013/10/29/216

Changes in V8:
============
* Renaming driver and related files from ibm-power-idle to powerpc-book3s-idle
for clarity and to avoid confusing between ibm-power systems and power mgmt.

Changes in V7:
============
* Rebased to the latest kernel 3.12-rc7

* Default idle routine to be called on POWERNV
is power7_idle() instead of HMT_low() routines.

Changes in V6:
=============
* Made changes in Patch3: Generic POWER cpuidle driver in V5 by breaking down to multiple patches, as there were multiple changes including moving the file location.

* Remove MAX_IDLE_STATE macro and kernel command line for IBM-POWER systems.

* Make backend driver a built-in, instead of a module. As building this as a module is currently not possible.

* Generic backend driver minor cleanups.

* First two patches in V5 are not a part of the series, as they are generic cleanups, already pushed into the tree.

Changes in V5:
=============

* As per the discussions in the community, this patch series enables cpuidle backend driver only for IBM-POWER platforms. File is re-named from drivers/cpuidle/cpuidle-powerpc.c to drivers/cpuidle/cpuildle-ibm-power.c
New back-end cpuidle driver is called IBM-POWER-Idle.

* General cleanups on the accessors front that was introduced in previous version.

Changes in V4:
=============

* This patch series includes generic backend driver cpuidle cleanups including, replacing the driver and device initialisation routines with cpuidle_register function.

* Enable CPUIDLE framework only for POWER and POWERNV platforms.

Changes in V3:
=============

* This patch series does not include smt-snooze-delay fixes. This will be taken up later on.

* Integrated POWERPC driver in drivers/cpuidle. Enabled for all of POWERPC platform. Currently has PSERIES and POWERNV support. No compile time flags in .c file. This will be one consolidated binary that does a run time detection based on platform and take decisions accordingly.

* Enabled CPUIDLE framwork for all of PPC64.

Changes in V2:
=============

* Merged the backend driver posted out for powernv in V1 with pSeries to create a single powerpc driver but this had compile time flags.

Deepthi Dharwar (7):
pseries/cpuidle: Move processor_idle.c to drivers/cpuidle. pseries/cpuidle: Use cpuidle_register() for initialisation. pseries/cpuidle: Make pseries_idle backend driver a non-module. pseries/cpuidle: Remove MAX_IDLE_STATE macro.
POWER/cpuidle: Generic POWERPC-BOOK3S CPUIDLE driver supporting PSERIES. POWER/cpuidle: Enable powernv cpuidle support.
powernv/cpuidle: Enable idle powernv cpu to call into the cpuidle framework.

 arch/powerpc/include/asm/processor.h            |    2 
 arch/powerpc/platforms/powernv/setup.c          |   13 +
 arch/powerpc/platforms/pseries/Kconfig          |    9 -
 arch/powerpc/platforms/pseries/Makefile         |    1 
 arch/powerpc/platforms/pseries/processor_idle.c |  364 -----------------------
 drivers/cpuidle/Kconfig                         |    5 
 drivers/cpuidle/Kconfig.powerpc                 |   10 +
 drivers/cpuidle/Makefile                        |    4 
 drivers/cpuidle/cpuidle-powerpc-book3s.c        |  320 ++++++++++++++++++++
 9 files changed, 352 insertions(+), 376 deletions(-)
 delete mode 100644 arch/powerpc/platforms/pseries/processor_idle.c
 create mode 100644 drivers/cpuidle/Kconfig.powerpc
 create mode 100644 drivers/cpuidle/cpuidle-powerpc-book3s.c

-- Deepthi