Skip to content

RFC pci: bus and slot reset interfaces

Alex Williamson linux-pci 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest7 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7pci: Create pci_reset_bridge_secondary_bus()drivers/pci/pci.c include/linux/pci.h+24 -90 replies
2/7pci: Add hotplug_slot_ops.reset_slot()include/linux/pci_hotplug.h+4 -00 replies
3/7pci: Implement reset_slot for pciehpdrivers/pci/hotplug/pciehp.h drivers/pci/hotplug/pciehp_core.c drivers/pci/hotplug/pciehp_hpc.c+44 -00 replies
4/7pci: Add slot reset option to pci_dev_resetdrivers/pci/pci.c+34 -00 replies
5/7pci: Split out pci_dev lock/unlock and save/restoredrivers/pci/pci.c+35 -170 replies
6/7pci: Add slot and bus reset interfacesdrivers/pci/pci.c include/linux/pci.h+197 -00 replies
7/7pci: Wake-up devices before save for resetdrivers/pci/pci.c+7 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/7] pci: bus and slot reset interfaces

This series adds PCI bus and slot reset interfaces to the already existing function reset interface. I need this for two reasons, the first is that not all devices support function level reset. Even some of those that we detect as supporting a PM reset on D3hot->D0 transition actually don't do any reset. Others have no reset capability at all. We currently implement a secondary bus reset escalation from the function reset path, but only when there is a single devfn on the bus. Drivers like vfio can have ownership of all of the devices on a bus and should therefore have a path to initiate a secondary bus reset with multiple devices. This is particularly required for use of GPUs by userspace, where none of the predominant GPUs implement a useful function level reset.

The second reason is that even the current function reset escalating to a secondary bus reset can cause problems with hotplug controllers. If a root port supports PCIe HP with suprise removal, a bus reset can trigger a presence detection change, which results in an attempt to remove the struct device. By having a slot reset interface, we can involve the hotplug controllers to allow for a controlled bus reset and avoid this spurious removal attempt.

Takao-san also needs a PCI bus reset interface to quiesce devices during kexec. I believe this interface also provides that.

Why is this an RFC? I posted this a while back and self-nacked it because there were issues when hotplug was built as a module. Now that we're removing module support for PCI hotplug and pciehp in particular, I think that problem is resolved, but it needs further testing. Coments welcome. Thanks,

Alex

---

Alex Williamson (7):
pci: Create pci_reset_bridge_secondary_bus()
pci: Add hotplug_slot_ops.reset_slot()
pci: Implement reset_slot for pciehp
pci: Add slot reset option to pci_dev_reset
pci: Split out pci_dev lock/unlock and save/restore
pci: Add slot and bus reset interfaces
pci: Wake-up devices before save for reset

 drivers/pci/hotplug/pciehp.h      |    1 
 drivers/pci/hotplug/pciehp_core.c |   12 +
 drivers/pci/hotplug/pciehp_hpc.c  |   31 ++++
 drivers/pci/pci.c                 |  320 ++++++++++++++++++++++++++++++++++---
 include/linux/pci.h               |    3 
 include/linux/pci_hotplug.h       |    4 
 6 files changed, 345 insertions(+), 26 deletions(-)