Skip to content

tracing: Final fixes for the race between open event file and deleting event

Steven Rostedt lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5debugfs: debugfs_remove_recursive() must not rely on list_empty(d_subdirs)fs/debugfs/inode.c+22 -470 replies
2/5tracing: trace_remove_event_call() should fail if call/file is in useinclude/linux/ftrace_event.h kernel/trace/trace_events.c+34 -30 replies
3/5tracing: Add comment to describe special break case in probe_remove_event_call()kernel/trace/trace_events.c+6 -00 replies
4/5tracing/kprobes: Fail to unregister if probe event files are in usekernel/trace/trace_kprobe.c+15 -60 replies
5/5tracing/uprobes: Fail to unregister if probe event files are in usekernel/trace/trace_uprobe.c+38 -130 replies

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchOleg NesterovMasami HiramatsuGreg Kroah-Hartman
1/5A-b
2/5R-b
3/5
4/5A-b
5/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [for-next-3.11][PATCH 0/5] tracing: Final fixes for the race between open event file and deleting event

Oleg,

Is all the races that we are aware of between accessing event files and deleting events covered by these patches? I think I have them all. Was there any patches that I missed, as there were a lot of threads and lots of patches sent out, but not all were considered final.

I think I got the main ones that we decided on, but I'm not 100% sure as my INBOX is overrun by too many activities. It may be a few months before I go through them all.

I haven't pushed this to my for-next branch as I'm waiting for some feedback from others in my queue. But I did push it to my ftrace/urgent branch if you want to look at what will be going there. That branch may rebase but I wanted to get these patches tested by Fengguang before sending them to next. And I try not to rebase my for-next branch.

Thanks,

-- Steve

Oleg Nesterov (2):
debugfs: debugfs_remove_recursive() must not rely on list_empty(d_subdirs)
tracing: trace_remove_event_call() should fail if call/file is in use

Steven Rostedt (Red Hat) (3):
tracing: Add comment to describe special break case in probe_remove_event_call() tracing/kprobes: Fail to unregister if probe event files are in use tracing/uprobes: Fail to unregister if probe event files are in use

----

 fs/debugfs/inode.c           |   69 ++++++++++++++----------------------------
 include/linux/ftrace_event.h |    2 +-
 kernel/trace/trace_events.c  |   41 +++++++++++++++++++++++--
 kernel/trace/trace_kprobe.c  |   21 +++++++++----
 kernel/trace/trace_uprobe.c  |   51 +++++++++++++++++++++++--------
 5 files changed, 115 insertions(+), 69 deletions(-)