Skip to content

reiserfs locking patchset

[email protected] reiserfs-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3reiserfs: locking, push write lock out of xattr codefs/reiserfs/inode.c fs/reiserfs/super.c fs/reiserfs/xattr.c +1 more+70 -771 reply
2/3reiserfs: locking, handle nested locks properlyfs/reiserfs/bitmap.c fs/reiserfs/dir.c fs/reiserfs/fix_node.c +10 more+248 -1940 replies
3/3reiserfs: locking, release lock around quota operationsfs/reiserfs/bitmap.c fs/reiserfs/inode.c fs/reiserfs/lock.c +4 more+119 -800 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [patch 0/3] reiserfs locking patchset

This patchset untangles some of the locking in reiserfs. It has seen more testing as part of the maintenance cycle in SLE 11 SP2.

- We push the write lock out of the xattr code. It doesn't need it and we can simplify locking by releasing and reacquiring the locks around the xattr calls.

- Handle nested locks properly. There's confusion on when a lock is nested, when it's not, and how to drop it across schedules like the BKL it is modeled after. We make the distinction between taking/releasing the lock and when to drop it for schedules and simplify the logic. This fixes a number of deadlocks that happen because the intention was to drop the write lock but it really only decremented the use count.

- Fix the deadlocks with the quota code. This involves dropping the write lock before quota calls and reacquring it afterwards. Without this patch reiserfs quotas are essentially unusable.

Jan - This series is in the for-3.12 branch of git.kernel.org:/pub/scm/linux/kernel/git/jeffm/linux-reiserfs.git

Thanks.

-Jeff

Signature · 2 lines
Jeff Mahoney
SuSE Labs