Skip to content

xfsprogs: various issues from review

Ben Myers linux-xfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 of 14 patches 10 repliesIn review

7 of 14 patches are in this archive. The cover letter announces 14.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
2/14xfsprogs: XFS_AGF_NUM_BITS should be 13include/xfs_ag.h+1 -10 replies
3/14xfsprogs: pull in the rest of 93848a999cflibxfs/xfs_ialloc.c+1 -11 reply
4/14xfsprogs: fix gpl headers in xfs_symlinkinclude/xfs_symlink.h libxfs/xfs_symlink.c+2 -00 replies
5/14xfsprogs: sync commit f5f3d9b016 completelyinclude/xfs_dir2_format.h libxfs/xfs_dir2_data.c+3 -12 replies
6/14xfsprogs: cleanup some whitespacelibxfs/xfs_dir2_node.c+0 -31 reply
7/14xfsprogs: fix issues with commit 75c8b4343abbinclude/libxfs.h libxfs/rdwr.c repair/scan.c+4 -211 reply
8/14xfsprogs: fix issues with e0607266f23libxfs/xfs_alloc.c repair/dinode.c+5 -136 replies

Reviews trailers per patch

1 of 7 patches has a Reviewed-by or Acked-by.

PatchEric Sandeen
2/14
3/14
4/14
5/14
6/14
7/14
8/14R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/14] xfsprogs: various issues from review

Hey,

Quoted 21 lines · Ben Myers
Quoted 20 lines · Dave Chinner

Hi folks,

This is the latest update of the series of patches tht introduces CRC support into xfsprogs. Of note, for CRC enabled filesystems;

- write support for xfs-db is disabled
- obfuscation for metadump is disabled
- xfs_check does nothing ("always succeed") so that xfstests can run without needing this
- all structures shoul dbe supported for printing in xfs_db
- xfs_repair should be able to fully validate the structure of a CRC enabled filesystem.
- xfs_repair still ignores CRC validation errors when reading metadata
- mkfs.xfs enforces limitations on the format of CRC enabled filesystems (inode size, attr format, projid32bit, etc).
- whenever a v5 superblock is parsed on read by any utility, it outputs a wanring about it being an experimental format.

Quoted 3 lines
Quoted 1 line

Bug reports, patches, comments, reviews, etc all welcome.

Pulled in 1-48 of the first series and 1-12 of the second.

Here is a patch series that addresses some of my outstanding concerns from review. Some may be already fixed in the 2nd series, I'm not sure. Eric also mentioned that he put the updated branch through coverity and found some defects. There may be some overlap there too.

Some of these are just reminders for myself to make sure certain items are addressed eventually. Sorry for the noise.

-Ben

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs