dlm: kill the unnecessary and wrong device_close()->recalc_sigpending()
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest1 patch 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/1 | dlm: kill the unnecessary and wrong device_close()->recalc_sigpending()fs/ | +0 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/1] dlm: kill the unnecessary and wrong device_close()->recalc_sigpending()
Quoted 4 lines · Oleg Nesterov
And of course, there could be another bug. I just did "grep
recalc_sigpending" and immediately found at least one buggy user,fs/dlm/user.cwhich calls it lockless.
and the usage of sigprocmask() is wrong, see 1/1.
In fact there are more users which play with sigprocmask() this way. I am starting to think that, perhaps, we should implement some helpers for this use-case.
Oleg.