Skip to content

ftrace/rcu: Handle unsafe RCU functions and ftrace callbacks

Steven Rostedt lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest18 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18tracing: Make tracing_cpumask available for all instanceskernel/trace/trace.c kernel/trace/trace.h+21 -170 replies
2/18ftrace: Fix a slight race in modifying what function callback gets tracedkernel/trace/ftrace.c+16 -10 replies
3/18ftrace/rcu: Do not trace debug_lockdep_rcu_enabled()kernel/rcupdate.c+1 -10 replies
4/18ftrace: Add hash list to save RCU unsafe functionsinclude/asm-generic/vmlinux.lds.h include/linux/ftrace.h kernel/trace/ftrace.c+174 -90 replies
5/18ftrace: Do not set ftrace records for unsafe RCU when not allowedkernel/trace/ftrace.c+17 -20 replies
6/18ftrace: Set ftrace internal function tracing RCU safekernel/trace/ftrace.c+3 -10 replies
7/18ftrace: Add test for ops against unsafe RCU functions in callbackkernel/trace/ftrace.c+3 -10 replies
8/18ftrace: Do not display non safe RCU functions in available_filter_functionsinclude/linux/ftrace.h kernel/trace/ftrace.c+6 -10 replies
9/18ftrace: Add rcu_unsafe_filter_functions fileinclude/linux/ftrace.h kernel/trace/ftrace.c+32 -00 replies
10/18ftrace: Add selftest to check if RCU unsafe functions are filtered properlykernel/trace/trace.h kernel/trace/trace_selftest.c kernel/trace/trace_selftest_dynamic.c+103 -00 replies
11/18ftrace: Create a RCU unsafe checkerkernel/trace/Kconfig kernel/trace/ftrace.c kernel/trace/trace.h +1 more+84 -10 replies
12/18ftrace: Add infrastructure to stop RCU unsafe checker from checkingkernel/trace/trace.h kernel/trace/trace_functions.c+31 -30 replies
13/18ftrace: Disable RCU unsafe checker when function graph is enabledkernel/trace/ftrace.c+7 -00 replies
14/18ftrace: Disable the RCU unsafe checker when irqsoff is enabledkernel/trace/trace_irqsoff.c+14 -20 replies
15/18ftrace/lockdep: Have the RCU lockdep splat show what function triggeredinclude/linux/ftrace.h kernel/lockdep.c kernel/trace/trace_functions.c+21 -10 replies
16/18ftrace/rcu: Mark functions that are RCU unsafekernel/rcutiny.c kernel/rcutree.c+8 -01 reply
17/18ftrace/cpuidle/x86: Mark functions that are RCU unsafearch/x86/kernel/process.c drivers/cpuidle/cpuidle.c kernel/cpu/idle.c+6 -00 replies
18/18ftrace: Print a message when the rcu checker is disabledkernel/trace/trace_functions.c+4 -00 replies

Reviews trailers per patch

14 of 18 patches have a Reviewed-by or Acked-by.

PatchPaul E. McKenneyH. Peter AnvinRafael J. Wysocki
1/18
2/18
3/18R-b
4/18A-b
5/18A-b
6/18A-b
7/18A-b
8/18A-b
9/18A-b
10/18A-b
11/18A-b
12/18A-b
13/18
14/18
15/18A-b
16/18R-b
17/18A-b A-b A-b
18/18R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [for-next][PATCH 00/18] ftrace/rcu: Handle unsafe RCU functions and ftrace callbacks

This is the latest patches to be queued for 3.12.

A little late, but as Dave Jones has been stumbling over this for a while, I thought it would be good to get it in now. It's not that complex to resolve any issues that may pop up.

I'll keep it in linux-next for a while to make sure it really is clean.

Note, the checker will stumble over a few functions in irq and scheduler code if enabled. This is because those patches have not received Acks from Thomas Gleixner and Peter Zijlstra. When I get those acks, I'll add the changes to silent those too.

Thanks to Paul McKenney for reviewing the patches.

Enjoy,

-- Steve

git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
for-next

Head SHA1: 7fb3a66134ed5a40448131cf4195823d22f70aa3

Alexander Z Lam (1)
tracing: Make tracing_cpumask available for all instances

Steven Rostedt (Red Hat) (17)
ftrace: Fix a slight race in modifying what function callback gets traced ftrace/rcu: Do not trace debug_lockdep_rcu_enabled()
ftrace: Add hash list to save RCU unsafe functions
ftrace: Do not set ftrace records for unsafe RCU when not allowed
ftrace: Set ftrace internal function tracing RCU safe
ftrace: Add test for ops against unsafe RCU functions in callback
ftrace: Do not display non safe RCU functions in available_filter_functions
ftrace: Add rcu_unsafe_filter_functions file
ftrace: Add selftest to check if RCU unsafe functions are filtered properly
ftrace: Create a RCU unsafe checker
ftrace: Add infrastructure to stop RCU unsafe checker from checking
ftrace: Disable RCU unsafe checker when function graph is enabled
ftrace: Disable the RCU unsafe checker when irqsoff is enabled ftrace/lockdep: Have the RCU lockdep splat show what function triggered ftrace/rcu: Mark functions that are RCU unsafe ftrace/cpuidle/x86: Mark functions that are RCU unsafe
ftrace: Print a message when the rcu checker is disabled

----

 b/arch/x86/kernel/process.c             |    2 
 b/drivers/cpuidle/cpuidle.c             |    2 
 b/include/asm-generic/vmlinux.lds.h     |   10 +
 b/include/linux/ftrace.h                |   38 +++++
 b/kernel/cpu/idle.c                     |    2 
 b/kernel/lockdep.c                      |    2 
 b/kernel/rcupdate.c                     |    2 
 b/kernel/rcutiny.c                      |    1 
 b/kernel/rcutree.c                      |    7 +
 b/kernel/trace/Kconfig                  |   22 +++
 b/kernel/trace/ftrace.c                 |   17 ++
 b/kernel/trace/trace.c                  |   37 ++---
 b/kernel/trace/trace.h                  |    1 
 b/kernel/trace/trace_functions.c        |   48 ++++++-
 b/kernel/trace/trace_irqsoff.c          |   16 ++
 b/kernel/trace/trace_selftest.c         |   94 +++++++++++++
 b/kernel/trace/trace_selftest_dynamic.c |    7 +
 include/linux/ftrace.h                  |    8 +
 kernel/trace/ftrace.c                   |  218 +++++++++++++++++++++++++++++---
 kernel/trace/trace.h                    |   17 ++
 kernel/trace/trace_functions.c          |   40 +++++
 21 files changed, 551 insertions(+), 40 deletions(-)