Skip to content

WLAN regression fixes for omap4 after moving to DT based booting

Tony Lindgren linux-arm-kernel linux-omap 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 2 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] WLAN regression fixes for omap4 after moving to DT based booting
Quoted 6 lines · Olof Johansson

Hi,

Not related to wlan but with DT conversion; I noticed the following in dmesg on Panda ES with omap2plus_defconfig on current mainline:

[    0.000000] smp_twd: clock not found -2

That should get fixed for v3.13 when we get the proper DT clocks for omap. Currently twd_get_clock() currently does:

	if (np)
		twd_clk = of_clk_get(np, 0);
	else
		twd_clk = clk_get_sys("smp_twd", NULL);

So if fails in the np case right now.

I'd probably wait for v3.13 on this one to avoid adding temporary timer workarounds to twd_get_clock() or stuffing the clock for the timer by using of_clk_add_provider().

If people feel strongly that we should fix it for v3.12, then let me know. Things do work without it, of course the local timer is not being used though.

Quoted 3 lines

and:

[    0.440399] omap-gpmc 50000000.gpmc: error: clk_get

Thanks that's an easy one. I'll queue the following fix.

Regards,

Tony

From: Tony Lindgren <[email protected]>
Date: Mon, 16 Sep 2013 14:22:31 -0700
Subject: [PATCH] ARM: OMAP4: Fix clock_get error for GPMC during boot

Looks like we still have the legacy clock alias name for omap4 GPMC (General Purpose Memory Controller), so let's fix it for the device tree naming. There's no need to keep the legacy naming as omap4 is DT only nowadays.

Without this fix we get the following error while booting:

[    0.440399] omap-gpmc 50000000.gpmc: error: clk_get
arch/arm/mach-omap2/cclock44xx_data.c +1 -1
@@ -1632,7 +1632,7 @@ static struct omap_clk omap44xx_clks[] = {
 	CLK(NULL,	"auxclk5_src_ck",		&auxclk5_src_ck),
 	CLK(NULL,	"auxclk5_ck",			&auxclk5_ck),
 	CLK(NULL,	"auxclkreq5_ck",		&auxclkreq5_ck),
-	CLK("omap-gpmc",	"fck",			&dummy_ck),
+	CLK("50000000.gpmc",	"fck",			&dummy_ck),
 	CLK("omap_i2c.1",	"ick",			&dummy_ck),
 	CLK("omap_i2c.2",	"ick",			&dummy_ck),
 	CLK("omap_i2c.3",	"ick",			&dummy_ck),