Skip to content

Sparse-related updates for 3.13

Paul E. McKenney bridge linux-wireless lkml netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest14 patches 6 repliesIn review
  2. v213 patches 32 repliesSuperseded
  3. v113 patches 2 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14rcu: Add comment on evaluate-once properties of rcu_assign_pointer().include/linux/rcupdate.h+8 -00 replies
2/14notifiers: Apply ACCESS_ONCE() to avoid sparse false positivekernel/notifier.c+2 -10 replies
3/14bridge: Apply ACCESS_ONCE() to avoid sparse false positivenet/bridge/br_multicast.c+2 -20 replies
4/14wireless: Apply ACCESS_ONCE() to avoid sparse false positivenet/wireless/scan.c+18 -140 replies
5/14decnet: Apply ACCESS_ONCE() to avoid sparse false positivenet/decnet/dn_route.c+5 -30 replies
6/14ipv4/ip_socketglue: Apply ACCESS_ONCE() to avoid sparse false positivenet/ipv4/ip_sockglue.c+2 -10 replies
7/14ipv6/ip6_tunnel: Apply ACCESS_ONCE() to avoid sparse false positivenet/ipv6/ip6_tunnel.c+2 -10 replies
8/14ipv6/ip6_gre: Apply ACCESS_ONCE() to avoid sparse false positivenet/ipv6/ip6_gre.c+2 -10 replies
9/14ipv6/sit: Apply ACCESS_ONCE() to avoid sparse false positivenet/ipv6/sit.c+2 -10 replies
10/14mac80211: Apply ACCESS_ONCE() to avoid sparse false positivenet/mac80211/sta_info.c+4 -30 replies
11/14bridge/br_mdb: Apply ACCESS_ONCE() to avoid sparse false positivenet/bridge/br_mdb.c+1 -10 replies
12/14bonding/bond_main: Apply ACCESS_ONCE() to avoid sparse false positivedrivers/net/bonding/bond_main.c+5 -30 replies
13/14bonding/bond_alb.c: Apply ACCESS_ONCE() to avoid sparse false positivedrivers/net/bonding/bond_alb.c+2 -10 replies
14/14rcu: Make rcu_assign_pointer's assignment volatile and type-safeinclude/linux/rcupdate.h+11 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 tip/core/rcu 0/14] Sparse-related updates for 3.13

Hello!

This series features updates to allow sparse to do a better job of statically analyzing RCU usage:

1. Add a comment indicating that despite appearances,
rcu_assign_pointer() really only evaluates its arguments once, as a cpp macro should.

2-13. Apply ACCESS_ONCE() to avoid a number of rcu_assign_pointer()
calls that would otherwise suffer sparse false positives given patch #13 below.

14. Apply ACCESS_ONCE() to rcu_assign_pointer()'s target to prevent
comiler mischief. Also require that the source pointer be from the kernel address space. Sometimes it can be from the RCU address space, which necessitates the remaining patches in this series. Which, it must be admitted, apply to a very small fraction of the rcu_assign_pointer() invocations in the kernel. This commit courtesy of Josh Triplett.

Changes from v2:

o Switch from rcu_assign_pointer() to ACCESS_ONCE() given that
the pointers are all --rcu and already visible to readers, as suggested by Eric Dumazet and Josh Triplett.

o Place the commit adding the rcu_assign_pointer()'s ACCESS_ONCE()
at the end to allow better bisectability, as suggested by Josh Triplett.

o Add a comment to rcu_assign_pointer() noting that it only evaluates
its arguments once, as suggested by Josh Triplett.

Changes from v1:

o Fix grammar nit in commit logs.

Thanx, Paul

 b/drivers/net/bonding/bond_alb.c  |    3 ++-
 b/drivers/net/bonding/bond_main.c |    8 +++++---
 b/include/linux/rcupdate.h        |   20 +++++++++++++++++++-
 b/kernel/notifier.c               |    3 ++-
 b/net/bridge/br_mdb.c             |    2 +-
 b/net/bridge/br_multicast.c       |    4 ++--
 b/net/decnet/dn_route.c           |    8 +++++---
 b/net/ipv4/ip_sockglue.c          |    3 ++-
 b/net/ipv6/ip6_gre.c              |    3 ++-
 b/net/ipv6/ip6_tunnel.c           |    3 ++-
 b/net/ipv6/sit.c                  |    3 ++-
 b/net/mac80211/sta_info.c         |    7 ++++---
 b/net/wireless/scan.c             |   32 ++++++++++++++++++--------------
 13 files changed, 66 insertions(+), 33 deletions(-)