Skip to content

Add Core Divider clock support for Armada 370/XP

Ezequiel Garcia linux-arm-kernel linux-devicetree 2 versions New

Get series with b4
b4 am 1380224130-11868-1-git-send-email-ezequiel.garcia@free-electrons.com

Versions newest first · linked by author and title

  1. v2 Latest4 patches 0 repliesNew
  2. v10 of 5 patches 0 repliesSuperseded

Changes in v2 from the cover letter

* The most significative change is the simplification of the NAND clock tree. Instead of exposing two clocks: NAND ECC and NAND, we choose a simpler approach and view both clocks as one.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4clk: mvebu: Add Core Divider clockdrivers/clk/mvebu/Kconfig drivers/clk/mvebu/Makefile drivers/clk/mvebu/clk-corediv.c+229 -01 reply
1/4clk: mvebu: Add Core Divider clock+0 -00 replies
1/4clk: mvebu: Add Core Divider clock+0 -00 replies
1/4clk: mvebu: Add Core Divider clock+0 -00 replies
1/4clk: mvebu: Add Core Divider clock+0 -02 replies
1/4clk: mvebu: Add Core Divider clock+0 -00 replies
1/4clk: mvebu: Add Core Divider clock+0 -00 replies
1/4clk: mvebu: Add Core Divider clock+0 -00 replies
2/4ARM: mvebu: Add Core Divider clock device-tree bindingDocumentation/devicetree/bindings/clock/mvebu-corediv-clock.txt+19 -00 replies
3/4ARM: mvebu: Add a 2 GHz fixed-clock Armada 370/XParch/arm/boot/dts/armada-370-xp.dtsi+9 -00 replies
4/4ARM: mvebu: Add the core-divider clock to Armada 370/XParch/arm/boot/dts/armada-370-xp.dtsi+8 -00 replies

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by.

PatchGregory CLEMENTJason Cooper
1/4R-b A-b
1/4R-b A-b
1/4R-b A-b
1/4R-b A-b
1/4R-b A-b
1/4R-b A-b
1/4R-b A-b
1/4R-b A-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] Add Core Divider clock support for Armada 370/XP

This patchset adds support for a set of clocks available in Armada 370/XP known as "Core Divider" clocks.

These are a set of gatable clocks, derived from a fixed PLL at a configurable ratio. Although this patchset adds support for the more general case, we only support one of the clocks, namely the NAND clock.

With this infrastructure in place, the addition of the rest of the clocks would be fairly easy.

A pictorical representation of the clock tree would be:

    PLL
    |
    |
    ---------------------
    |			|
    |			|
    NAND clock		...

This patchset is based on v3.12-rc2. Any opinions are highly appreciated.

Thanks!

Changes from v1:

* The most significative change is the simplification of the NAND clock tree. Instead of exposing two clocks: NAND ECC and NAND, we choose a simpler approach and view both clocks as one.

The only impact these simplification has is that the NAND controller driver will have to divide the rate by two when using it to calculate the timings.

* A spinlock protecting the enable, disable and set_rate operations is added as noted by Andrew Lunn.

* The round_rate algorithm was also simplified, as the previous one was rather silly; also noted by Andrew.

* The size of the 'reg' property was fixed; also noted by Andrew.

* The exceedingly long macros names have been simplified and some other minor coding style issues have been solved.

Ezequiel Garcia (4):
clk: mvebu: Add Core Divider clock
ARM: mvebu: Add Core Divider clock device-tree binding
ARM: mvebu: Add a 2 GHz fixed-clock Armada 370/XP
ARM: mvebu: Add the core-divider clock to Armada 370/XP

 .../bindings/clock/mvebu-corediv-clock.txt         |  19 ++
 arch/arm/boot/dts/armada-370-xp.dtsi               |  17 ++
 drivers/clk/mvebu/Kconfig                          |   5 +
 drivers/clk/mvebu/Makefile                         |   1 +
 drivers/clk/mvebu/clk-corediv.c                    | 223 +++++++++++++++++++++
 5 files changed, 265 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/clock/mvebu-corediv-clock.txt
 create mode 100644 drivers/clk/mvebu/clk-corediv.c
Signature · 1 line
1.8.1.5