RFC ARM: cleanup gd init
Get series with b4
b4 am 20130928223932.2f831bb0@lilithVersions newest first
- v1 RFC Latest0 of 3 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 3 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [U-Boot] [RFC 0/3] ARM: cleanup gd init
Hi Jeroen,
Quoted 6 lines · Jeroen Hofstee
Hello,
Quoted 3 lines · Jeroen Hofstee
4) Keep the
s_initincrt0.Sor move it to theboard_init_f? The disadvantage of the later is that all the different board_init_f's need to callsystem_init.
Quoted 7 lines
Since this has been on the mailing-list for a month without a reply, let's push this a bit.
Moving
s_inittoboard_init_fis not smart since there are manyboard_init_falready and likely there will be more in the future since SPL uses it as well. It also provides a chance to save bootrom registers to gd. Afterboad_init_fr1 is clobbered at least..
Not sure what you mean by there being "many" board_init_f()s -- I count five occurrences, one of which is the standard board_init_f(), one is a weak default in SPL, and three are custom versions; the last four may or may not be merged into 'the' board_init_f() one.
Regarding saving bootrom (or other) registers, that is a feature for start.S, more precisely from _start, which is the only place in the whole of U-Boot that has not clobbered any register yet.
The right process is thus to split s_init(): any part that deals with saving registers at boot should go in start.S; any part that deals with anything else and is not absolutely required before entering crt0.S should move in a function called from board_init_f().
Quoted 2 lines
Regards,
Jeroen
Amicalement,
Signature · 1 line
Albert.