Skip to content

sched, wait: Collapse __wait_event macros -v4

Peter Zijlstra lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6sched, wait: Make the signal_pending() checks consistentinclude/linux/tty.h include/linux/wait.h+22 -260 replies
2/6sched, wait: Change timeout logicinclude/linux/wait.h+11 -132 replies
3/6sched, wait: Change the wait_exclusive control flowinclude/linux/wait.h+5 -40 replies
4/6sched, wait: Collapse __wait_event macrosinclude/linux/tty.h include/linux/wait.h+63 -1500 replies
5/6sched, wait: Also use ___wait_event() for __wait_event_hrtimeoutinclude/linux/wait.h+2 -130 replies
6/6sched, wait: Make the __wait_event*() interface more friendlyarch/mips/kernel/rtlx.c include/linux/tty.h include/linux/wait.h +2 more+73 -811 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] sched, wait: Collapse __wait_event macros -v4

While poking at the cpu hotplug implementation I had a desire to use wait_event() with schedule_preempt_disabled() and found the rediculous amount of duplication in linux/wait.h.

These patches attempt to cure some of this while also making it 'trivial' to generate new variants.

Compile and boot tested on x86_64.

Changes since -v3:
- added LKML to the CC (D'0h!!)
- introduced ___wait_cond_timeout() to avoid double evalutation of 'condition'

Changes since -v2:
- removed ___wait_cmd_lock_irq(), ___wait_cmd_lock_irq_timo()
- renamed ___wait_cmd_test_timeout() to ___wait_test_timeout()
- renamed ___wait_cmd_schedule_timeout() to ___wait_sched_timeout()
- fixed schedule_timeout() invocations in patch 6; don't restart a schedule_timeout() at the total timeout; rather continue where we left off for a total fixed timeout.
- use 'long' return type for ___wait_event() so that timeout values for schedule_timeout() fit.
- fix wait_event_interruptible_lock_irq_timeout() and use long return type.

---
 arch/mips/kernel/rtlx.c         |   19 +-
 include/linux/tty.h             |   28 +---
 include/linux/wait.h            |  268 +++++++++++++---------------------------
 net/irda/af_irda.c              |    5 
 net/netfilter/ipvs/ip_vs_sync.c |    7 -
 5 files changed, 108 insertions(+), 219 deletions(-)