Add support for the Allwinner A31 Reset Controllers
Get series with b4
b4 am 20131006082917.GD3106@lukatherVersions newest first
- v1 Latest0 of 4 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 4 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [linux-sunxi] [PATCH 0/4] Add support for the Allwinner A31 Reset Controllers
Hi Roman,
Quoted 4 lines · Arokux X
Quoted 2 lines · Maxime Ripard
Hi everyone,
Quoted 8 lines
Quoted 4 lines
This patchset adds support for the reset controllers found in the Allwinner A31 SoCs. Since these controllers are pretty simple, basically just a few MMIO registers, with a single bit controlling the reset state of the other devices it asserts in reset, the driver is quite simple as well.
I think we need something smarter here. There are reset bits all over the place. After a hint by Emilio and small chat with Oliver I've realized I have 3 reset bits in USB host clock module [0].
I wasn't aware there were other IPs behaving like this in older SoCs. Thanks for pointing this out.
Something smarter in what sense? It's just one bit to put in one register, I don't really see how it can be "smart".
Quoted 3 lines
Maybe implementation like this one [1] where a mask can be passed as a parameter will be more appropriate? (Those reset bits behave the same as gatable clocks really.)
No, they don't behave like gatable clocks, and they shouldn't be implemented with the clock framework. Whenever you disable a clock, the child device will retain its configuration, while with the reset part, well, it will just be reset. This makes one huge difference.
We have a shiny new reset framework for this, made exactly for these cases, why not use it?
Thanks,
Maxime
Signature · 10 lines
Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131006/a347db60/attachment.sig>